[binutils-gdb] PR 26580 revert 36efe0aea5f7

Alan Modra amodra@sourceware.org
Thu Sep 10 08:41:49 GMT 2026


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e5adeeb9d3e62d7ba7c577d1677cb77761007b6a

commit e5adeeb9d3e62d7ba7c577d1677cb77761007b6a
Author: Alan Modra <amodra@gmail.com>
Date:   Thu Sep 10 18:02:13 2026 +0930

    PR 26580 revert 36efe0aea5f7
    
    In commit 36efe0aea5f7 I wrote "Some MIPS targets, for reasons I
    didn't analyse ..", which of course is a foolish reason to "fix" a
    failure of a new testcase.  The failure is due to the common sym in
    the shared library being made SHN_MIPS_DATA in
    _bfd_mips_elf_finish_dynamic_symbol, and thus being treated as a
    normal data symbol when linking against a common symbol in the
    relocatable object file.  Reverting the patch results in
    mips*-elf  +FAIL: pr26580-1
    mips*-elf  +FAIL: pr26580-2
    mips-sgi-irix6  +FAIL: pr26580-1
    mips-sgi-irix6  +FAIL: pr26580-2
    I reckon that is correct, because it looks to me that these targets
    don't treat BSS symbols in a shared library properly.

Diff:
---
 ld/testsuite/ld-elf/pr26580-2.sd | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ld/testsuite/ld-elf/pr26580-2.sd b/ld/testsuite/ld-elf/pr26580-2.sd
index 10474ca23d4..265b880f81a 100644
--- a/ld/testsuite/ld-elf/pr26580-2.sd
+++ b/ld/testsuite/ld-elf/pr26580-2.sd
@@ -1,4 +1,4 @@
 
 #...
-.* (8 OBJECT  GLOBAL DEFAULT .*|0 OBJECT  GLOBAL DEFAULT  UND) one
+.* 8 OBJECT  GLOBAL DEFAULT .* one
 #pass


More information about the Binutils-cvs mailing list