[binutils-gdb] x86/disasm: do not use format string without format specifiers
H.J. Lu
hjl@sourceware.org
Tue May 26 23:58:33 GMT 2026
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f845edf617dda2758e0eab9afd54a9444df01712
commit f845edf617dda2758e0eab9afd54a9444df01712
Author: Will Hawkins <hawkinsw@obs.cr>
Date: Sun May 24 00:08:24 2026 -0400
x86/disasm: do not use format string without format specifiers
Fixes PR binutils/34168: build failure with -Werror=format-security.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34168
Signed-off-by: Will Hawkins <hawkinsw@obs.cr>
Diff:
---
opcodes/i386-dis.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c
index 3c5f173648a..db1e4f7a7d5 100644
--- a/opcodes/i386-dis.c
+++ b/opcodes/i386-dis.c
@@ -10375,7 +10375,7 @@ print_insn (bfd_vma pc, disassemble_info *info, int intel_syntax)
for (i = 0; i < MAX_OPERANDS; i++)
if (ins.op_index[i] != -1 && ins.op_riprel[i])
{
- i386_dis_printf (info, dis_style_comment_start, sep);
+ i386_dis_printf (info, dis_style_comment_start, "%s", sep);
sep = ", ";
(*info->print_address_func)
((bfd_vma)(ins.start_pc + (ins.codep - ins.start_codep)
@@ -10384,7 +10384,7 @@ print_insn (bfd_vma pc, disassemble_info *info, int intel_syntax)
}
else if (*ins.cm_out[i])
{
- i386_dis_printf (info, dis_style_comment_start, sep);
+ i386_dis_printf (info, dis_style_comment_start, "%s", sep);
sep = ", ";
i386_dis_printf (info, dis_style_symbol, "%s", ins.cm_out[i]);
}
More information about the Binutils-cvs
mailing list