[binutils-gdb] gas: sframe: fix inaccurate function-level comment
Indu Bhagat
ibhagat@sourceware.org
Tue Jan 20 22:13:46 GMT 2026
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1afad6269c55f4d719ea04a184843fa30109777f
commit 1afad6269c55f4d719ea04a184843fa30109777f
Author: Indu Bhagat <indu.bhagat@oracle.com>
Date: Tue Jan 20 14:07:10 2026 -0800
gas: sframe: fix inaccurate function-level comment
gas/
* gen-sframe.c (sframe_xlate_do_register): Fix code comments.
Diff:
---
gas/gen-sframe.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c
index af18cba6643..90c8aeb12cc 100644
--- a/gas/gen-sframe.c
+++ b/gas/gen-sframe.c
@@ -1492,15 +1492,11 @@ sframe_xlate_do_val_offset (const struct sframe_xlate_ctx *xlate_ctx ATTRIBUTE_U
/* Translate DW_CFA_register into SFrame context.
This opcode indicates: Previous value of register1 is register2. This is
- not representable in SFrame stack trace format. Detect the use of registers
+ not representable using FDE type SFRAME_FDE_TYPE_DEFAULT. Hence, if
+ flexible FDE is not enabled for the ABI/arch, detect the use of registers
interesting to SFrame (FP, RA for this opcode), and skip FDE generation
- while warning the user.
-
- Two exceptions apply though:
- - for S390X, the stack offsets are used to carry register number in
- default FDE types. So invoke S390X specific handling.
- - for AMD64, the flexible topmost frame encoding
- SFRAME_FDE_TYPE_FLEX can be used for FP, RA registers.
+ while warning the user. Same applies for SP, except that it needs special
+ handling for s390.
Return SFRAME_XLATE_OK if success. */
More information about the Binutils-cvs
mailing list