[binutils-gdb] BFD: Remove extraneous BFD struct member setup from `bfd_make_readable'

Maciej W. Rozycki macro@sourceware.org
Tue Jan 20 15:30:48 GMT 2026


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8d52534fa398ac83a5619518d060d8c942025ee0

commit 8d52534fa398ac83a5619518d060d8c942025ee0
Author: Maciej W. Rozycki <macro@redhat.com>
Date:   Tue Jan 20 15:29:15 2026 +0000

    BFD: Remove extraneous BFD struct member setup from `bfd_make_readable'
    
    Complementing commit 3097045a18a8 ("ld plugin bfd_make_readable leak")
    remove assignments to BFD struct members from `bfd_make_readable' that
    now duplicate ones unconditionally made by `_bfd_free_cached_info'
    called earlier on.

Diff:
---
 bfd/opncls.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/bfd/opncls.c b/bfd/opncls.c
index 624c958febf..8bbbcd5d326 100644
--- a/bfd/opncls.c
+++ b/bfd/opncls.c
@@ -1032,15 +1032,12 @@ bfd_make_readable (bfd *abfd)
   abfd->origin = 0;
   abfd->opened_once = false;
   abfd->output_has_begun = false;
-  abfd->usrdata = NULL;
   abfd->cacheable = false;
   abfd->mtime_set = false;
 
   abfd->target_defaulted = true;
   abfd->direction = read_direction;
   abfd->symcount = 0;
-  abfd->outsymbols = 0;
-  abfd->tdata.any = 0;
   abfd->size = 0;
 
   bfd_check_format (abfd, bfd_object);


More information about the Binutils-cvs mailing list