[binutils-gdb] elf: Drop the FIXME comment in set_symbol_value
H.J. Lu
hjl@sourceware.org
Fri Oct 24 21:26:06 GMT 2025
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4b0d1b38bf8b4d3e4ce6bd990c46f574ae316ca8
commit 4b0d1b38bf8b4d3e4ce6bd990c46f574ae316ca8
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Sat Oct 25 05:10:49 2025 +0800
elf: Drop the FIXME comment in set_symbol_value
Since
commit aeaaa9af6359c8e394ce9cf24911fec4f4d23703
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Tue Sep 23 08:52:26 2025 +0800
elf: Return error on unsorted symbol table if not allowed
returns false when get_link_hash_entry returns NULL, we can drop the FIXME
comment now.
PR ld/33450
* elflink.c (set_symbol_value): Drop the FIXME comment.
Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
Diff:
---
bfd/elflink.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/bfd/elflink.c b/bfd/elflink.c
index fd0e549eb10..9862559b0fc 100644
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -9123,10 +9123,7 @@ set_symbol_value (bfd *bfd_with_globals,
to "defined" and give it a value. */
h = get_link_hash_entry (elf_sym_hashes (bfd_with_globals), symidx, extsymoff);
if (h == NULL)
- {
- /* FIXMEL What should we do ? */
- return false;
- }
+ return false;
h->root.type = bfd_link_hash_defined;
h->root.u.def.value = val;
h->root.u.def.section = bfd_abs_section_ptr;
More information about the Binutils-cvs
mailing list