[binutils-gdb] ld: Pass $NOPIE_CFLAGS and $NOPIE_LDFLAGS to test pr21964-4

Jens Remus jremus@sourceware.org
Fri Mar 28 14:28:50 GMT 2025


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=07468ded302ecaec1114f2d5c4d94e05c631f2ac

commit 07468ded302ecaec1114f2d5c4d94e05c631f2ac
Author: Jens Remus <jremus@linux.ibm.com>
Date:   Fri Mar 28 15:27:11 2025 +0100

    ld: Pass $NOPIE_CFLAGS and $NOPIE_LDFLAGS to test pr21964-4
    
    Linker test "pr21964-4" fails on s390x on Ubuntu 24.10 but not on
    Fedora 41.  The reason is that GCC on Ubuntu is configured with
    --enable-default-pie, so that it defaults to compile with -fPIE
    and link with -pie, which causes the test to erroneously fail.
    
    ld/testsuite/
            PR ld/21090
            * ld-elf/shared.exp: Compile pr21964-4 with $NOPIE_CFLAGS and
            link with $NOPIE_LDFLAGS.
    
    Bug: https://sourceware.org/PR21090
    Signed-off-by: Jens Remus <jremus@linux.ibm.com>

Diff:
---
 ld/testsuite/ld-elf/shared.exp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ld/testsuite/ld-elf/shared.exp b/ld/testsuite/ld-elf/shared.exp
index fa6357202f0..09669b5483c 100644
--- a/ld/testsuite/ld-elf/shared.exp
+++ b/ld/testsuite/ld-elf/shared.exp
@@ -1618,12 +1618,12 @@ if { [istarget *-*-linux*]
 	] \
 	[list \
 	    "Run pr21964-4" \
-	    "" \
+	    "$NOPIE_LDFLAGS" \
 	    "" \
 	    {pr21964-4.c} \
 	    "pr21964-4" \
 	    "pass.out" \
-	    "" \
+	    "$NOPIE_CFLAGS" \
 	    "" \
 	    "" \
 	    "-ldl" \


More information about the Binutils-cvs mailing list