[binutils-gdb] RISC-V: Fixed riscv_update_subset1 returning wrong boolean value

Nelson Chu nelsonc1225@sourceware.org
Tue Mar 18 04:22:53 GMT 2025


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=921d65b3f0751b714f9859496946e9560001b18f

commit 921d65b3f0751b714f9859496946e9560001b18f
Author: Nelson Chu <nelson@rivosinc.com>
Date:   Thu Mar 13 10:31:34 2025 +0800

    RISC-V: Fixed riscv_update_subset1 returning wrong boolean value
    
    The riscv_update_subset1 returning wrong boolean value if the
    riscv_parse_check_conflicts isn't called, though the current return value
    doesn't really useful.

Diff:
---
 bfd/elfxx-riscv.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
index fd2cb74df80..ffcf32be69e 100644
--- a/bfd/elfxx-riscv.c
+++ b/bfd/elfxx-riscv.c
@@ -2524,13 +2524,13 @@ riscv_update_subset1 (riscv_parse_subset_t *rps,
     }
   while (*p++ == ',');
 
-  bool conflict = false;
+  bool no_conflict = true;
   if (explicit_subset == NULL)
     {
       riscv_parse_add_implicit_subsets (rps);
-      conflict = riscv_parse_check_conflicts (rps);
+      no_conflict = riscv_parse_check_conflicts (rps);
     }
-  return conflict;
+  return no_conflict;
 }
 
 /* Add/Remove an extension to/from the subset list.  This is used for


More information about the Binutils-cvs mailing list