[binutils-gdb] {,E}COFF: use is_end_of_stmt()

Jan Beulich jbeulich@sourceware.org
Fri Mar 7 07:10:12 GMT 2025


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2d677125936a61ada1df87d34840d55cbe4250ae

commit 2d677125936a61ada1df87d34840d55cbe4250ae
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Mar 7 08:08:14 2025 +0100

    {,E}COFF: use is_end_of_stmt()
    
    ... instead of open-coding it. Convert a variable's type to plain char
    then as well, as that's what it's really holding (and how it's used
    everywhere else).

Diff:
---
 gas/config/obj-coff.c | 4 ++--
 gas/ecoff.c           | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gas/config/obj-coff.c b/gas/config/obj-coff.c
index 6072af669fc..19759cddc5e 100644
--- a/gas/config/obj-coff.c
+++ b/gas/config/obj-coff.c
@@ -1572,13 +1572,13 @@ obj_coff_section (int ignore ATTRIBUTE_UNUSED)
 	exp = get_absolute_expression ();
       else
 	{
-	  unsigned char attr;
+	  char attr;
 	  int readonly_removed = 0;
 	  int load_removed = 0;
 
 	  while (attr = *++input_line_pointer,
 		 attr != '"'
-		 && ! is_end_of_line[attr])
+		 && ! is_end_of_stmt (attr))
 	    {
 	      if (ISDIGIT (attr))
 		{
diff --git a/gas/ecoff.c b/gas/ecoff.c
index f665f1158a4..756aa927946 100644
--- a/gas/ecoff.c
+++ b/gas/ecoff.c
@@ -3351,7 +3351,7 @@ ecoff_directive_weakext (int ignore ATTRIBUTE_UNUSED)
 
       ++input_line_pointer;
       SKIP_WHITESPACE ();
-      if (! is_end_of_line[(unsigned char) *input_line_pointer])
+      if (! is_end_of_stmt (*input_line_pointer))
 	{
 	  expression (&exp);
 	  if (exp.X_op != O_symbol)


More information about the Binutils-cvs mailing list