[binutils-gdb] gas md_apply_fix value casts
Alan Modra
amodra@sourceware.org
Tue Jun 10 22:27:38 GMT 2025
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2cfc7485d5a13e2af8ca3f6944e3a74d22a1b347
commit 2cfc7485d5a13e2af8ca3f6944e3a74d22a1b347
Author: Alan Modra <amodra@gmail.com>
Date: Mon Jun 9 17:00:48 2025 +0930
gas md_apply_fix value casts
These are all innocuous but unneeded. pdp11 and ppc are only formatting.
Diff:
---
gas/config/tc-cris.c | 5 ++---
gas/config/tc-metag.c | 2 +-
gas/config/tc-microblaze.c | 2 +-
gas/config/tc-mmix.c | 9 ++++-----
gas/config/tc-mn10300.c | 2 +-
gas/config/tc-pdp11.c | 6 +++---
gas/config/tc-ppc.c | 2 +-
gas/config/tc-rl78.c | 2 +-
gas/config/tc-rx.c | 8 ++++----
gas/config/tc-sh.c | 2 +-
gas/config/tc-wasm32.c | 2 +-
11 files changed, 20 insertions(+), 22 deletions(-)
diff --git a/gas/config/tc-cris.c b/gas/config/tc-cris.c
index 2ceac0ed201..5780386e585 100644
--- a/gas/config/tc-cris.c
+++ b/gas/config/tc-cris.c
@@ -4039,9 +4039,8 @@ void
md_apply_fix (fixS *fixP, valueT *valP, segT seg)
{
/* This assignment truncates upper bits if valueT is 64 bits (as with
- --enable-64-bit-bfd), which is fine here, though we cast to avoid
- any compiler warnings. */
- long val = (long) *valP;
+ --enable-64-bit-bfd), which is fine here. */
+ long val = *valP;
char *buf = fixP->fx_where + fixP->fx_frag->fr_literal;
if (fixP->fx_addsy == 0 && !fixP->fx_pcrel)
diff --git a/gas/config/tc-metag.c b/gas/config/tc-metag.c
index cd0c50ff9c9..bb8e897b57a 100644
--- a/gas/config/tc-metag.c
+++ b/gas/config/tc-metag.c
@@ -7029,7 +7029,7 @@ void
md_apply_fix (fixS *fixP, valueT *valP, segT seg ATTRIBUTE_UNUSED)
{
char *buf = fixP->fx_where + fixP->fx_frag->fr_literal;
- int value = (int)*valP;
+ int value = *valP;
switch (fixP->fx_r_type)
{
diff --git a/gas/config/tc-microblaze.c b/gas/config/tc-microblaze.c
index 3bf2ac16fe7..917b8f64c80 100644
--- a/gas/config/tc-microblaze.c
+++ b/gas/config/tc-microblaze.c
@@ -2042,7 +2042,7 @@ md_apply_fix (fixS * fixP,
const char * file = fixP->fx_file ? fixP->fx_file : _("unknown");
const char * symname;
/* Note: use offsetT because it is signed, valueT is unsigned. */
- offsetT val = (offsetT) * valp;
+ offsetT val = *valp;
int i;
struct op_code_struct * opcode1;
unsigned long inst1;
diff --git a/gas/config/tc-mmix.c b/gas/config/tc-mmix.c
index eb29b14d1ae..dea91816b0f 100644
--- a/gas/config/tc-mmix.c
+++ b/gas/config/tc-mmix.c
@@ -2426,12 +2426,11 @@ md_convert_frag (bfd *abfd ATTRIBUTE_UNUSED, segT sec ATTRIBUTE_UNUSED,
void
md_apply_fix (fixS *fixP, valueT *valP, segT segment)
{
- char *buf = fixP->fx_where + fixP->fx_frag->fr_literal;
+ char *buf = fixP->fx_where + fixP->fx_frag->fr_literal;
/* Note: use offsetT because it is signed, valueT is unsigned. */
- offsetT val = (offsetT) * valP;
- segT symsec
- = (fixP->fx_addsy == NULL
- ? absolute_section : S_GET_SEGMENT (fixP->fx_addsy));
+ offsetT val = *valP;
+ segT symsec = (fixP->fx_addsy == NULL
+ ? absolute_section : S_GET_SEGMENT (fixP->fx_addsy));
/* If the fix is relative to a symbol which is not defined, or, (if
pcrel), not in the same segment as the fix, we cannot resolve it
diff --git a/gas/config/tc-mn10300.c b/gas/config/tc-mn10300.c
index 55747e0280a..c4cf8040055 100644
--- a/gas/config/tc-mn10300.c
+++ b/gas/config/tc-mn10300.c
@@ -2325,7 +2325,7 @@ md_apply_fix (fixS * fixP, valueT * valP, segT seg)
{
char * fixpos = fixP->fx_where + fixP->fx_frag->fr_literal;
int size = 0;
- int value = (int) * valP;
+ int value = *valP;
gas_assert (fixP->fx_r_type < BFD_RELOC_UNUSED);
diff --git a/gas/config/tc-pdp11.c b/gas/config/tc-pdp11.c
index 7566bbbcbff..2c8a1b891c9 100644
--- a/gas/config/tc-pdp11.c
+++ b/gas/config/tc-pdp11.c
@@ -239,12 +239,12 @@ md_number_to_chars (char con[], valueT value, int nbytes)
void
md_apply_fix (fixS *fixP,
- valueT * valP,
- segT seg ATTRIBUTE_UNUSED)
+ valueT *valP,
+ segT seg ATTRIBUTE_UNUSED)
{
valueT code;
valueT mask;
- valueT val = * valP;
+ valueT val = *valP;
char *buf;
int shift;
int size;
diff --git a/gas/config/tc-ppc.c b/gas/config/tc-ppc.c
index 43dddb0d907..714dfca4670 100644
--- a/gas/config/tc-ppc.c
+++ b/gas/config/tc-ppc.c
@@ -6964,7 +6964,7 @@ ppc_handle_align (segT sec, struct frag *fragP)
void
md_apply_fix (fixS *fixP, valueT *valP, segT seg)
{
- valueT value = * valP;
+ valueT value = *valP;
offsetT fieldval;
const struct powerpc_operand *operand;
diff --git a/gas/config/tc-rl78.c b/gas/config/tc-rl78.c
index 6d24bc3ecb5..3593b00fb96 100644
--- a/gas/config/tc-rl78.c
+++ b/gas/config/tc-rl78.c
@@ -1420,7 +1420,7 @@ md_apply_fix (struct fix * f ATTRIBUTE_UNUSED,
return;
op = f->fx_frag->fr_literal + f->fx_where;
- val = (unsigned long) * t;
+ val = *t;
if (f->fx_addsy == NULL)
f->fx_done = 1;
diff --git a/gas/config/tc-rx.c b/gas/config/tc-rx.c
index bd45c53cfa0..0ecda6411e8 100644
--- a/gas/config/tc-rx.c
+++ b/gas/config/tc-rx.c
@@ -2256,9 +2256,9 @@ rx_cons_fix_new (fragS * frag,
}
void
-md_apply_fix (struct fix * f ATTRIBUTE_UNUSED,
- valueT * t ATTRIBUTE_UNUSED,
- segT s ATTRIBUTE_UNUSED)
+md_apply_fix (struct fix *f,
+ valueT *t,
+ segT s ATTRIBUTE_UNUSED)
{
/* Instruction bytes are always little endian. */
char * op;
@@ -2274,7 +2274,7 @@ md_apply_fix (struct fix * f ATTRIBUTE_UNUSED,
#define OP4(x) op[target_big_endian ? 3-x : x]
op = f->fx_frag->fr_literal + f->fx_where;
- val = (unsigned long) * t;
+ val = *t;
/* Opcode words are always the same endian. Data words are either
big or little endian. */
diff --git a/gas/config/tc-sh.c b/gas/config/tc-sh.c
index 0f890c98cc9..9620eef9e93 100644
--- a/gas/config/tc-sh.c
+++ b/gas/config/tc-sh.c
@@ -3396,7 +3396,7 @@ md_apply_fix (fixS *fixP, valueT *valP, segT seg ATTRIBUTE_UNUSED)
char *buf = fixP->fx_where + fixP->fx_frag->fr_literal;
int lowbyte = target_big_endian ? 1 : 0;
int highbyte = target_big_endian ? 0 : 1;
- long val = (long) *valP;
+ long val = *valP;
long max, min;
int shift;
diff --git a/gas/config/tc-wasm32.c b/gas/config/tc-wasm32.c
index ea47a02bd0c..066255f8994 100644
--- a/gas/config/tc-wasm32.c
+++ b/gas/config/tc-wasm32.c
@@ -204,7 +204,7 @@ void
md_apply_fix (fixS * fixP, valueT * valP, segT seg ATTRIBUTE_UNUSED)
{
char *buf = fixP->fx_where + fixP->fx_frag->fr_literal;
- long val = (long) *valP;
+ valueT val = *valP;
if (fixP->fx_pcrel)
{
More information about the Binutils-cvs
mailing list