[binutils-gdb] gas fixups
Alan Modra
amodra@sourceware.org
Wed Jul 9 00:07:18 GMT 2025
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=48753009c1812b4182e72bf5265ac85d7931a152
commit 48753009c1812b4182e72bf5265ac85d7931a152
Author: Alan Modra <amodra@gmail.com>
Date: Wed Jul 9 09:12:45 2025 +0930
gas fixups
Remove unnecessary arg casts in fix_new and similar calls.
Diff:
---
gas/config/tc-aarch64.c | 2 +-
gas/config/tc-alpha.c | 4 ++--
gas/config/tc-csky.c | 2 +-
gas/config/tc-hppa.c | 32 +++++++++++++-------------------
gas/config/tc-ns32k.c | 8 ++++----
gas/config/tc-rl78.c | 2 +-
gas/config/tc-rx.c | 2 +-
gas/config/tc-sparc.c | 2 +-
gas/config/tc-spu.c | 14 ++------------
gas/config/tc-vax.c | 2 +-
10 files changed, 27 insertions(+), 43 deletions(-)
diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
index b52d4b705de..9d2ae950a95 100644
--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -10123,7 +10123,7 @@ cons_fix_new_aarch64 (fragS * frag, int where, int size, expressionS * exp)
}
#endif
- fix_new_exp (frag, where, (int) size, exp, pcrel, type);
+ fix_new_exp (frag, where, size, exp, pcrel, type);
}
/* Implement md_after_parse_args. This is the earliest time we need to decide
diff --git a/gas/config/tc-alpha.c b/gas/config/tc-alpha.c
index a91db143ab9..4a9255873b0 100644
--- a/gas/config/tc-alpha.c
+++ b/gas/config/tc-alpha.c
@@ -3394,8 +3394,8 @@ add_to_link_pool (symbolS *sym, offsetT addend)
expsym = make_expr_symbol (&e);
/* Create a fixup for the entry. */
- fixp = fix_new
- (frag_now, p - frag_now->fr_literal, 8, sym, addend, 0, BFD_RELOC_64);
+ fixp = fix_new (frag_now, p - frag_now->fr_literal, 8,
+ sym, addend, 0, BFD_RELOC_64);
fixp->tc_fix_data.info = get_alpha_reloc_tag (next_sequence_num--);
fixp->tc_fix_data.info->sym = expsym;
diff --git a/gas/config/tc-csky.c b/gas/config/tc-csky.c
index 9a7749edf69..eca6ff17878 100644
--- a/gas/config/tc-csky.c
+++ b/gas/config/tc-csky.c
@@ -5320,7 +5320,7 @@ csky_cons_fix_new (fragS *frag,
reloc = BFD_RELOC_32;
break;
}
- fixP = fix_new_exp (frag, off, (int) len, exp, 0, reloc);
+ fixP = fix_new_exp (frag, off, len, exp, 0, reloc);
if (BFD_RELOC_CKCORE_TLS_IE32 == insn_reloc
|| BFD_RELOC_CKCORE_TLS_GD32 == insn_reloc
|| BFD_RELOC_CKCORE_TLS_LDM32 == insn_reloc)
diff --git a/gas/config/tc-hppa.c b/gas/config/tc-hppa.c
index b147bdc1713..f1175e0d4e3 100644
--- a/gas/config/tc-hppa.c
+++ b/gas/config/tc-hppa.c
@@ -1265,8 +1265,7 @@ cons_fix_new_hppa (fragS *frag, int where, int size, expressionS *exp,
hppa_field_selector = e_fsel;
}
- fix_new_hppa (frag, where, size,
- (symbolS *) NULL, (offsetT) 0, exp, 0, rel_type,
+ fix_new_hppa (frag, where, size, NULL, 0, exp, 0, rel_type,
hppa_field_selector, size * 8, 0, 0);
}
@@ -5762,7 +5761,7 @@ md_assemble (char *str)
where = frag_more (0);
u = UNWIND_LOW32 (&last_call_info->ci_unwind.descriptor);
fix_new_hppa (frag_now, where - frag_now->fr_literal, 0,
- NULL, (offsetT) 0, NULL,
+ NULL, 0, NULL,
0, R_HPPA_ENTRY, e_fsel, 0, 0, u);
}
#endif
@@ -5786,7 +5785,7 @@ md_assemble (char *str)
/* If necessary output more stuff. */
if (the_insn.reloc != R_HPPA_NONE)
fix_new_hppa (frag_now, (to - frag_now->fr_literal), 4, NULL,
- (offsetT) 0, &the_insn.exp, the_insn.pcrel,
+ 0, &the_insn.exp, the_insn.pcrel,
(int) the_insn.reloc, the_insn.field_selector,
the_insn.format, the_insn.arg_reloc, 0);
@@ -5856,7 +5855,7 @@ pa_brtab (int begin ATTRIBUTE_UNUSED)
char *where = frag_more (0);
fix_new_hppa (frag_now, where - frag_now->fr_literal, 0,
- NULL, (offsetT) 0, NULL,
+ NULL, 0, NULL,
0, begin ? R_HPPA_BEGIN_BRTAB : R_HPPA_END_BRTAB,
e_fsel, 0, 0, 0);
#endif
@@ -5880,7 +5879,7 @@ pa_try (int begin ATTRIBUTE_UNUSED)
the beginning and end of exception handling regions). */
fix_new_hppa (frag_now, where - frag_now->fr_literal, 0,
- NULL, (offsetT) 0, begin ? NULL : &exp,
+ NULL, 0, begin ? NULL : &exp,
0, begin ? R_HPPA_BEGIN_TRY : R_HPPA_END_TRY,
e_fsel, 0, 0, 0);
#endif
@@ -6019,10 +6018,8 @@ pa_build_unwind_subspace (struct call_info *call_info)
/* Relocation info. for start offset of the function. */
md_number_to_chars (p, 0, 4);
- fix_new_hppa (frag_now, p - frag_now->fr_literal, 4,
- symbolP, (offsetT) 0,
- (expressionS *) NULL, 0, reloc,
- e_fsel, 32, 0, 0);
+ fix_new_hppa (frag_now, p - frag_now->fr_literal, 4, symbolP, 0,
+ NULL, 0, reloc, e_fsel, 32, 0, 0);
/* Relocation info. for end offset of the function.
@@ -6033,9 +6030,8 @@ pa_build_unwind_subspace (struct call_info *call_info)
finished with its work. */
md_number_to_chars (p + 4, 0, 4);
fix_new_hppa (frag_now, p + 4 - frag_now->fr_literal, 4,
- call_info->end_symbol, (offsetT) 0,
- (expressionS *) NULL, 0, reloc,
- e_fsel, 32, 0, 0);
+ call_info->end_symbol, 0,
+ NULL, 0, reloc, e_fsel, 32, 0, 0);
/* Dump the descriptor. */
unwind = UNWIND_LOW32 (&call_info->ci_unwind.descriptor);
@@ -6335,8 +6331,7 @@ pa_entry (int unused ATTRIBUTE_UNUSED)
where = frag_more (0);
u = UNWIND_LOW32 (&last_call_info->ci_unwind.descriptor);
fix_new_hppa (frag_now, where - frag_now->fr_literal, 0,
- NULL, (offsetT) 0, NULL,
- 0, R_HPPA_ENTRY, e_fsel, 0, 0, u);
+ NULL, 0, NULL, 0, R_HPPA_ENTRY, e_fsel, 0, 0, u);
}
#endif
}
@@ -6494,8 +6489,7 @@ process_exit (void)
if we split the unwind bits up between the relocations which
denote the entry and exit points. */
fix_new_hppa (frag_now, where - frag_now->fr_literal, 0,
- NULL, (offsetT) 0,
- NULL, 0, R_HPPA_EXIT, e_fsel, 0, 0,
+ NULL, 0, NULL, 0, R_HPPA_EXIT, e_fsel, 0, 0,
UNWIND_HIGH32 (&last_call_info->ci_unwind.descriptor));
#endif
}
@@ -7011,8 +7005,8 @@ pa_procend (int unused ATTRIBUTE_UNUSED)
where = frag_more (0);
u = UNWIND_LOW32 (&last_call_info->ci_unwind.descriptor);
fix_new_hppa (frag_now, where - frag_now->fr_literal, 0,
- NULL, (offsetT) 0, NULL,
- 0, R_HPPA_ENTRY, e_fsel, 0, 0, u);
+ NULL, 0, NULL, 0, R_HPPA_ENTRY, e_fsel,
+ 0, 0, u);
}
#endif
}
diff --git a/gas/config/tc-ns32k.c b/gas/config/tc-ns32k.c
index 11e39280012..dcabf5f5555 100644
--- a/gas/config/tc-ns32k.c
+++ b/gas/config/tc-ns32k.c
@@ -1758,7 +1758,7 @@ convert_iif (void)
the object later. */
exprP.X_add_number += iif.iifP[i].object_adjust;
fix_new_ns32k_exp (frag_now,
- (long) (memP - frag_now->fr_literal),
+ memP - frag_now->fr_literal,
size,
&exprP,
iif.iifP[i].pcrel,
@@ -1806,12 +1806,12 @@ convert_iif (void)
size = default_disp_size; /* Normally 4 bytes. */
memP = frag_more (size);
fix_new_ns32k_exp (frag_now,
- (long) (memP - frag_now->fr_literal),
+ memP - frag_now->fr_literal,
size,
&exprP,
0, /* never iif.iifP[i].pcrel, */
1, /* always iif.iifP[i].im_disp */
- (bit_fixS *) 0, 0,
+ 0, 0,
inst_frag,
inst_offset);
break; /* Exit this absolute hack. */
@@ -2053,7 +2053,7 @@ md_estimate_size_before_relax (fragS *fragP, segT segment)
/* We don't relax symbols defined in another segment. The
thing to do is to assume the object will occupy 4 bytes. */
fix_new_ns32k (fragP,
- (int) (fragP->fr_fix),
+ fragP->fr_fix,
4,
fragP->fr_symbol,
fragP->fr_offset,
diff --git a/gas/config/tc-rl78.c b/gas/config/tc-rl78.c
index 3593b00fb96..a20e8b17247 100644
--- a/gas/config/tc-rl78.c
+++ b/gas/config/tc-rl78.c
@@ -705,7 +705,7 @@ rl78_cons_fix_new (fragS * frag,
type = BFD_RELOC_RL78_DIFF;
}
- fixP = fix_new_exp (frag, where, (int) size, exp, 0, type);
+ fixP = fix_new_exp (frag, where, size, exp, 0, type);
switch (exp->X_md)
{
/* These are intended to have values larger than the container,
diff --git a/gas/config/tc-rx.c b/gas/config/tc-rx.c
index 0ecda6411e8..8685df10e26 100644
--- a/gas/config/tc-rx.c
+++ b/gas/config/tc-rx.c
@@ -2252,7 +2252,7 @@ rx_cons_fix_new (fragS * frag,
type = BFD_RELOC_RX_DIFF;
}
- fix_new_exp (frag, where, (int) size, exp, 0, type);
+ fix_new_exp (frag, where, size, exp, 0, type);
}
void
diff --git a/gas/config/tc-sparc.c b/gas/config/tc-sparc.c
index ec17a2f75fd..062cb479a07 100644
--- a/gas/config/tc-sparc.c
+++ b/gas/config/tc-sparc.c
@@ -4934,7 +4934,7 @@ cons_fix_new_sparc (fragS *frag,
}
}
- fix_new_exp (frag, where, (int) nbytes, exp, 0, r);
+ fix_new_exp (frag, where, nbytes, exp, 0, r);
}
void
diff --git a/gas/config/tc-spu.c b/gas/config/tc-spu.c
index f19ca7ee48f..5da4e00a48e 100644
--- a/gas/config/tc-spu.c
+++ b/gas/config/tc-spu.c
@@ -725,12 +725,7 @@ md_create_short_jump (char *ptr,
ptr[1] = 0x00;
ptr[2] = 0x00;
ptr[3] = 0x00;
- fix_new (frag,
- ptr - frag->fr_literal,
- 4,
- to_symbol,
- (offsetT) 0,
- 0,
+ fix_new (frag, ptr - frag->fr_literal, 4, to_symbol, 0, 0,
BFD_RELOC_SPU_PCREL16);
}
@@ -747,12 +742,7 @@ md_create_long_jump (char *ptr,
ptr[1] = 0x00;
ptr[2] = 0x00;
ptr[3] = 0x00;
- fix_new (frag,
- ptr - frag->fr_literal,
- 4,
- to_symbol,
- (offsetT) 0,
- 0,
+ fix_new (frag, ptr - frag->fr_literal, 4, to_symbol, 0, 0,
BFD_RELOC_SPU_PCREL16);
}
#endif
diff --git a/gas/config/tc-vax.c b/gas/config/tc-vax.c
index 9670b1aae32..1705380f8aa 100644
--- a/gas/config/tc-vax.c
+++ b/gas/config/tc-vax.c
@@ -3354,7 +3354,7 @@ vax_cons_fix_new (fragS *frag, int where, unsigned int nbytes, expressionS *exp,
: nbytes == 2 ? BFD_RELOC_16
: BFD_RELOC_32);
- fix_new_exp (frag, where, (int) nbytes, exp, 0, r);
+ fix_new_exp (frag, where, nbytes, exp, 0, r);
}
const char *
More information about the Binutils-cvs
mailing list