[binutils-gdb] Fix known minor objdump leak
Alan Modra
amodra@sourceware.org
Wed Jan 15 11:49:59 GMT 2025
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1439d7d5f3d0c3000a3ace64a0759625937f71cc
commit 1439d7d5f3d0c3000a3ace64a0759625937f71cc
Author: Alan Modra <amodra@gmail.com>
Date: Tue Jan 14 21:06:32 2025 +1030
Fix known minor objdump leak
* objdump.c (main): Free disassembler_options.
Diff:
---
binutils/objdump.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/binutils/objdump.c b/binutils/objdump.c
index 80044dea580..ebe586e0e3a 100644
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -6001,12 +6001,14 @@ main (int argc, char **argv)
{
char *options;
if (disassembler_options)
- /* Ignore potential memory leak for now. */
options = concat (disassembler_options, ",",
optarg, (const char *) NULL);
else
- options = optarg;
+ options = xstrdup (optarg);
+ free (disassembler_options);
disassembler_options = remove_whitespace_and_extra_commas (options);
+ if (!disassembler_options)
+ free (options);
}
break;
case 'j':
More information about the Binutils-cvs
mailing list