[binutils-gdb] C4x: use is_whitespace()

Jan Beulich jbeulich@sourceware.org
Mon Feb 3 11:27:10 GMT 2025


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=87f56f9149d4b1a78153f9f2fe381de39a12557e

commit 87f56f9149d4b1a78153f9f2fe381de39a12557e
Author: Jan Beulich <jbeulich@suse.com>
Date:   Mon Feb 3 12:25:01 2025 +0100

    C4x: use is_whitespace()
    
    Wherever blanks are permissible in input, tabs ought to be permissible,
    too. This is particularly relevant when -f is passed to gas (alongside
    appropriate input). At the same time use is_end_of_stmt() instead of
    kind-of-open-coded checks in adjacent code.

Diff:
---
 gas/config/tc-tic4x.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gas/config/tc-tic4x.c b/gas/config/tc-tic4x.c
index c8afd1638a1..d7d31ab9558 100644
--- a/gas/config/tc-tic4x.c
+++ b/gas/config/tc-tic4x.c
@@ -1472,7 +1472,7 @@ tic4x_indirect_parse (tic4x_operand_t *operand,
 	  s++;
 	}
     }
-  if (*s != ' ' && *s != ',' && *s != '\0')
+  if (!is_whitespace (*s) && *s != ',' && !is_end_of_stmt (*s))
     return 0;
   input_line_pointer = s;
   return 1;
@@ -2428,7 +2428,7 @@ md_assemble (char *str)
       /* Find mnemonic (second part of parallel instruction).  */
       s = str;
       /* Skip past instruction mnemonic.  */
-      while (*s && *s != ' ')
+      while (!is_end_of_stmt (*s) && !is_whitespace (*s))
 	s++;
       if (*s)			/* Null terminate for str_hash_find.  */
 	*s++ = '\0';		/* and skip past null.  */
@@ -2492,7 +2492,7 @@ md_assemble (char *str)
     {
       /* Find mnemonic.  */
       s = str;
-      while (*s && *s != ' ')	/* Skip past instruction mnemonic.  */
+      while (!is_end_of_stmt (*s) && !is_whitespace (*s))	/* Skip past instruction mnemonic.  */
 	s++;
       if (*s)			/* Null terminate for str_hash_find.  */
 	*s++ = '\0';		/* and skip past null.  */


More information about the Binutils-cvs mailing list