[binutils-gdb] mn10200: use is_whitespace()

Jan Beulich jbeulich@sourceware.org
Mon Feb 3 11:17:07 GMT 2025


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=61c81ade8b40e8d0f525c14c7cefa4f5f315ce26

commit 61c81ade8b40e8d0f525c14c7cefa4f5f315ce26
Author: Jan Beulich <jbeulich@suse.com>
Date:   Mon Feb 3 12:14:56 2025 +0100

    mn10200: use is_whitespace()
    
    Wherever blanks are permissible in input, tabs ought to be permissible,
    too. This is particularly relevant when -f is passed to gas (alongside
    appropriate input). Also convert open-coded checks as well as ISSPACE()
    uses. At the same time use is_end_of_stmt() instead of kind-of-open-
    coded checks in adjacent code.

Diff:
---
 gas/config/tc-mn10200.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gas/config/tc-mn10200.c b/gas/config/tc-mn10200.c
index d630929f8c6..657f591a1b2 100644
--- a/gas/config/tc-mn10200.c
+++ b/gas/config/tc-mn10200.c
@@ -878,7 +878,7 @@ md_assemble (char *str)
   int match;
 
   /* Get the opcode.  */
-  for (s = str; *s != '\0' && !ISSPACE (*s); s++)
+  for (s = str; !is_end_of_stmt (*s) && !is_whitespace (*s); s++)
     ;
   if (*s != '\0')
     *s++ = '\0';
@@ -892,7 +892,7 @@ md_assemble (char *str)
     }
 
   str = s;
-  while (ISSPACE (*str))
+  while (is_whitespace (*str))
     ++str;
 
   input_line_pointer = str;
@@ -929,7 +929,7 @@ md_assemble (char *str)
 
 	  errmsg = NULL;
 
-	  while (*str == ' ' || *str == ',')
+	  while (is_whitespace (*str) || *str == ',')
 	    ++str;
 
 	  if (operand->flags & MN10200_OPERAND_RELAX)
@@ -1102,7 +1102,7 @@ md_assemble (char *str)
 	  str = input_line_pointer;
 	  input_line_pointer = hold;
 
-	  while (*str == ' ' || *str == ',')
+	  while (is_whitespace (*str) || *str == ',')
 	    ++str;
 
 	}
@@ -1127,10 +1127,10 @@ md_assemble (char *str)
       break;
     }
 
-  while (ISSPACE (*str))
+  while (is_whitespace (*str))
     ++str;
 
-  if (*str != '\0')
+  if (!is_end_of_stmt (*str))
     as_bad (_("junk at end of line: `%s'"), str);
 
   input_line_pointer = str;


More information about the Binutils-cvs mailing list