[binutils-gdb] Make gdb/guile codespell-clean
Tom Tromey
tromey@sourceware.org
Fri Apr 4 03:05:48 GMT 2025
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c619da1a22fcc67654b6c7860272aa2ce5deadaa
commit c619da1a22fcc67654b6c7860272aa2ce5deadaa
Author: Tom Tromey <tom@tromey.com>
Date: Thu Apr 3 12:11:15 2025 -0600
Make gdb/guile codespell-clean
This cleans up the last codespell reports in the Guile directory and
adds gdb/guile to pre-commit.
It also tells codespell to ignore URLs. I think this is warranted
because many URLs don't really contain words per se; and furthermore
if any URL-checking is needed at all, it would be for liveness and not
spelling.
Also I was wondering why the codespell config is in contrib and not
gdb/setup.cfg.
Approved-By: Tom de Vries <tdevries@suse.de>
Diff:
---
.pre-commit-config.yaml | 2 +-
gdb/contrib/setup.cfg | 3 +++
gdb/guile/scm-value.c | 2 +-
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 27eaea05985..488e7812f94 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -69,7 +69,7 @@ repos:
rev: v2.4.1
hooks:
- id: codespell
- files: '^(gdbsupport|gdbserver|gdb/(tui|target|data-directory|po|system-gdbinit|mi|syscalls|arch|regformats|compile|python))/'
+ files: '^(gdbsupport|gdbserver|gdb/(tui|target|data-directory|po|system-gdbinit|mi|syscalls|arch|regformats|compile|python|guile))/'
args: [--config, gdb/contrib/setup.cfg]
- repo: local
hooks:
diff --git a/gdb/contrib/setup.cfg b/gdb/contrib/setup.cfg
index dbff1651f4d..670a85064e2 100644
--- a/gdb/contrib/setup.cfg
+++ b/gdb/contrib/setup.cfg
@@ -4,3 +4,6 @@
skip = */ChangeLog*,*/configure,gdbsupport/Makefile.in,*.dat,*.eps,gdb/features/*.c,gdb/ada-casefold.h,gdb/copying.c,gdb/gdbarch-gen.h,gdb/gdbarch-gen.c,gdb/target-delegates-gen.c
ignore-words = gdb/contrib/codespell-ignore-words.txt
+
+# Ignore all URLs.
+uri-ignore-words-list = *
diff --git a/gdb/guile/scm-value.c b/gdb/guile/scm-value.c
index 0f4a6a46da0..88132e0e168 100644
--- a/gdb/guile/scm-value.c
+++ b/gdb/guile/scm-value.c
@@ -604,7 +604,7 @@ gdbscm_value_dynamic_type (SCM self)
type = value_rtti_type (value, NULL, NULL, NULL);
else
{
- /* Re-use object's static type. */
+ /* Reuse object's static type. */
type = NULL;
}
}
More information about the Binutils-cvs
mailing list