[binutils-gdb] binutils/testsuite: don't tail the same input and output file

Clement Chigot helflym@sourceware.org
Tue Apr 1 08:21:28 GMT 2025


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=71320db6509e0893607e9343b5af56a8c130a2ed

commit 71320db6509e0893607e9343b5af56a8c130a2ed
Author: Clément Chigot <chigot@adacore.com>
Date:   Mon Mar 31 10:42:43 2025 +0200

    binutils/testsuite: don't tail the same input and output file
    
    The output file could be created before the input is gathered by tail,
    erasing the later before it's being proceeded.
    
    This happened on rare cases when performing remote tests on
    Ubuntu 24.04.

Diff:
---
 binutils/testsuite/binutils-all/objdump.exp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp
index bddb0cb618a..f3142b10442 100644
--- a/binutils/testsuite/binutils-all/objdump.exp
+++ b/binutils/testsuite/binutils-all/objdump.exp
@@ -595,8 +595,8 @@ if { ![is_elf_format] } then {
        send_log "\n"
     }
 
-    set got [remote_exec host "tail -n +4 tmpdir/objdump.out" "" "/dev/null" "tmpdir/objdump.out"]
-    set output [remote_upload host tmpdir/objdump.out]
+    set got [remote_exec host "tail -n +4 tmpdir/objdump.out" "" "/dev/null" "tmpdir/objdump.tail"]
+    set output [remote_upload host tmpdir/objdump.tail]
 
     if ![file size $output] then {
        # If the output file is empty, then this target does not
@@ -606,7 +606,7 @@ if { ![is_elf_format] } then {
        return
     }
 
-    if { [regexp_diff tmpdir/objdump.out $srcdir/$subdir/dw5-op.W] } then {
+    if { [regexp_diff tmpdir/objdump.tail $srcdir/$subdir/dw5-op.W] } then {
        fail "objdump -Wi for DW_OP_*"
     } else {
        pass "objdump -Wi for DW_OP_*"


More information about the Binutils-cvs mailing list