[binutils-gdb] Fix -Wstringop-overflow warning in ecoff_link_hash_newfunc

Andreas Schwab schwab@sourceware.org
Thu Sep 26 11:57:24 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d31c9cf54ace96819fd8dff16ea120c578d89a46

commit d31c9cf54ace96819fd8dff16ea120c578d89a46
Author: Andreas Schwab <schwab@suse.de>
Date:   Thu Sep 26 13:06:25 2024 +0200

    Fix -Wstringop-overflow warning in ecoff_link_hash_newfunc
    
            * ecoff.c (ecoff_link_hash_newfunc): Don't call memset if ret is
            NULL.

Diff:
---
 bfd/ecoff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bfd/ecoff.c b/bfd/ecoff.c
index 04501761bd6..5ee7ffaf489 100644
--- a/bfd/ecoff.c
+++ b/bfd/ecoff.c
@@ -3278,8 +3278,8 @@ ecoff_link_hash_newfunc (struct bfd_hash_entry *entry,
       ret->abfd = NULL;
       ret->written = 0;
       ret->small = 0;
+      memset ((void *) &ret->esym, 0, sizeof ret->esym);
     }
-  memset ((void *) &ret->esym, 0, sizeof ret->esym);
 
   return (struct bfd_hash_entry *) ret;
 }


More information about the Binutils-cvs mailing list