[binutils-gdb/binutils-2_42-branch] Re: Move bfd_init to bfd.c

[Alan Modra]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=cb11047e34adf6d71689a828f3ee0b0d6a0f8938

commit cb11047e34adf6d71689a828f3ee0b0d6a0f8938
Author: Alan Modra <amodra@gmail.com>
Date:   Sat Mar 9 19:48:48 2024 +1030

    Re: Move bfd_init to bfd.c
    
    Commit b1c95bc4dd73 cleared some bfd static variables, with bad
    results since bfd_set_error_program_name is often called before
    bfd_init.
    
            * bfd.c (bfd_init): Don't clear _bfd_error_program_name.
    
    (cherry picked from commit 0c947d990a92fd48ac0aa887df7e1e055fa0d680)

Diff:
---
 bfd/bfd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/bfd/bfd.c b/bfd/bfd.c
index 0776145af52..36f5321164c 100644
--- a/bfd/bfd.c
+++ b/bfd/bfd.c
@@ -1742,7 +1742,6 @@ bfd_init (void)
   input_bfd = NULL;
   _bfd_clear_error_data ();
   input_error = bfd_error_no_error;
-  _bfd_error_program_name = NULL;
   _bfd_error_internal = error_handler_fprintf;
   _bfd_assert_handler = _bfd_default_assert_handler;