[binutils-gdb] gas: correct sb_add_char() 2nd parameter type

Jan Beulich jbeulich@sourceware.org
Fri Jul 26 06:01:33 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b8b1a4388835bf2899bb0cc148db42a2c32e2af6

commit b8b1a4388835bf2899bb0cc148db42a2c32e2af6
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Jul 26 08:01:07 2024 +0200

    gas: correct sb_add_char() 2nd parameter type
    
    It's entirely unclear why size_t was used there; my only guess is copy-
    and-paste from another of the functions.

Diff:
---
 gas/sb.c | 2 +-
 gas/sb.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gas/sb.c b/gas/sb.c
index e96355d2659..8eb47c9bed0 100644
--- a/gas/sb.c
+++ b/gas/sb.c
@@ -173,7 +173,7 @@ sb_reset (sb *ptr)
 /* Add character c to the end of the sb at ptr.  */
 
 void
-sb_add_char (sb *ptr, size_t c)
+sb_add_char (sb *ptr, char c)
 {
   sb_check (ptr, 1);
   ptr->ptr[ptr->len++] = c;
diff --git a/gas/sb.h b/gas/sb.h
index c9601969916..2507d35e1e2 100644
--- a/gas/sb.h
+++ b/gas/sb.h
@@ -57,7 +57,7 @@ extern void sb_kill (sb *);
 extern void sb_add_sb (sb *, sb *);
 extern void sb_scrub_and_add_sb (sb *, sb *);
 extern void sb_reset (sb *);
-extern void sb_add_char (sb *, size_t);
+extern void sb_add_char (sb *, char);
 extern void sb_add_string (sb *, const char *);
 extern void sb_add_buffer (sb *, const char *, size_t);
 extern char *sb_terminate (sb *);


More information about the Binutils-cvs mailing list