[binutils-gdb] MIPS: correct macro use in gas and ld testsuites

Jan Beulich jbeulich@sourceware.org
Fri Jul 19 09:59:03 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c0e9aca554e33e900efbd6425c1830f0a20012f5

commit c0e9aca554e33e900efbd6425c1830f0a20012f5
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Jul 19 11:58:04 2024 +0200

    MIPS: correct macro use in gas and ld testsuites
    
    Whitespace in macro arguments either needs quoting / parenthesizing to
    reliably not be mistaken for an argument separator, or respective macro
    parameters need to be marked as covering all remaining arguments. The
    former appears more appropriate here, as the macro parameters already
    have ":req".

Diff:
---
 gas/testsuite/gas/mips/unaligned-branch-1.s           | 4 ++--
 gas/testsuite/gas/mips/unaligned-branch-2.s           | 4 ++--
 gas/testsuite/gas/mips/unaligned-branch-micromips-1.s | 4 ++--
 gas/testsuite/gas/mips/unaligned-branch-micromips-2.s | 4 ++--
 gas/testsuite/gas/mips/unaligned-branch-mips16-1.s    | 4 ++--
 gas/testsuite/gas/mips/unaligned-branch-mips16-2.s    | 4 ++--
 gas/testsuite/gas/mips/unaligned-branch-r6-1.s        | 4 ++--
 gas/testsuite/gas/mips/unaligned-branch-r6-2.s        | 4 ++--
 gas/testsuite/gas/mips/unaligned-branch-r6-3.s        | 4 ++--
 gas/testsuite/gas/mips/unaligned-branch-r6-4.s        | 4 ++--
 gas/testsuite/gas/mips/unaligned-jump-1.s             | 4 ++--
 gas/testsuite/gas/mips/unaligned-jump-2.s             | 4 ++--
 gas/testsuite/gas/mips/unaligned-jump-micromips-1.s   | 4 ++--
 gas/testsuite/gas/mips/unaligned-jump-micromips-2.s   | 4 ++--
 gas/testsuite/gas/mips/unaligned-jump-mips16-1.s      | 4 ++--
 gas/testsuite/gas/mips/unaligned-jump-mips16-2.s      | 4 ++--
 ld/testsuite/ld-mips-elf/unaligned-data.s             | 2 +-
 ld/testsuite/ld-mips-elf/unaligned-insn.s             | 2 +-
 ld/testsuite/ld-mips-elf/unaligned-text.s             | 2 +-
 19 files changed, 35 insertions(+), 35 deletions(-)

diff --git a/gas/testsuite/gas/mips/unaligned-branch-1.s b/gas/testsuite/gas/mips/unaligned-branch-1.s
index bc976a29471..b99a63e6a1a 100644
--- a/gas/testsuite/gas/mips/unaligned-branch-1.s
+++ b/gas/testsuite/gas/mips/unaligned-branch-1.s
@@ -116,7 +116,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -127,7 +127,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-branch-2.s b/gas/testsuite/gas/mips/unaligned-branch-2.s
index 2f892c77a20..9a60d27f2af 100644
--- a/gas/testsuite/gas/mips/unaligned-branch-2.s
+++ b/gas/testsuite/gas/mips/unaligned-branch-2.s
@@ -117,7 +117,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -129,7 +129,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-branch-micromips-1.s b/gas/testsuite/gas/mips/unaligned-branch-micromips-1.s
index bec74ed1412..ada52839774 100644
--- a/gas/testsuite/gas/mips/unaligned-branch-micromips-1.s
+++ b/gas/testsuite/gas/mips/unaligned-branch-micromips-1.s
@@ -181,7 +181,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -192,7 +192,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-branch-micromips-2.s b/gas/testsuite/gas/mips/unaligned-branch-micromips-2.s
index e65601e2094..f3f39803ba4 100644
--- a/gas/testsuite/gas/mips/unaligned-branch-micromips-2.s
+++ b/gas/testsuite/gas/mips/unaligned-branch-micromips-2.s
@@ -182,7 +182,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -194,7 +194,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-branch-mips16-1.s b/gas/testsuite/gas/mips/unaligned-branch-mips16-1.s
index d4fad965962..6bc8b2919bf 100644
--- a/gas/testsuite/gas/mips/unaligned-branch-mips16-1.s
+++ b/gas/testsuite/gas/mips/unaligned-branch-mips16-1.s
@@ -85,7 +85,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -96,7 +96,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-branch-mips16-2.s b/gas/testsuite/gas/mips/unaligned-branch-mips16-2.s
index 0a6e55327ac..5476cae40dc 100644
--- a/gas/testsuite/gas/mips/unaligned-branch-mips16-2.s
+++ b/gas/testsuite/gas/mips/unaligned-branch-mips16-2.s
@@ -86,7 +86,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -98,7 +98,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-branch-r6-1.s b/gas/testsuite/gas/mips/unaligned-branch-r6-1.s
index 1e5960cbe09..0e48b29fb2d 100644
--- a/gas/testsuite/gas/mips/unaligned-branch-r6-1.s
+++ b/gas/testsuite/gas/mips/unaligned-branch-r6-1.s
@@ -118,7 +118,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -129,7 +129,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-branch-r6-2.s b/gas/testsuite/gas/mips/unaligned-branch-r6-2.s
index dc89ea0f81e..c1607011f6d 100644
--- a/gas/testsuite/gas/mips/unaligned-branch-r6-2.s
+++ b/gas/testsuite/gas/mips/unaligned-branch-r6-2.s
@@ -118,7 +118,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -129,7 +129,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-branch-r6-3.s b/gas/testsuite/gas/mips/unaligned-branch-r6-3.s
index beb59128d03..62adac29ae6 100644
--- a/gas/testsuite/gas/mips/unaligned-branch-r6-3.s
+++ b/gas/testsuite/gas/mips/unaligned-branch-r6-3.s
@@ -119,7 +119,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -131,7 +131,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-branch-r6-4.s b/gas/testsuite/gas/mips/unaligned-branch-r6-4.s
index 26a905af853..cb5ef695dd8 100644
--- a/gas/testsuite/gas/mips/unaligned-branch-r6-4.s
+++ b/gas/testsuite/gas/mips/unaligned-branch-r6-4.s
@@ -119,7 +119,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -131,7 +131,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-jump-1.s b/gas/testsuite/gas/mips/unaligned-jump-1.s
index bfdd0d3ea14..13f85c715fc 100644
--- a/gas/testsuite/gas/mips/unaligned-jump-1.s
+++ b/gas/testsuite/gas/mips/unaligned-jump-1.s
@@ -116,7 +116,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -127,7 +127,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-jump-2.s b/gas/testsuite/gas/mips/unaligned-jump-2.s
index f6a951ddeca..b2a60ab61a0 100644
--- a/gas/testsuite/gas/mips/unaligned-jump-2.s
+++ b/gas/testsuite/gas/mips/unaligned-jump-2.s
@@ -117,7 +117,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -129,7 +129,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-jump-micromips-1.s b/gas/testsuite/gas/mips/unaligned-jump-micromips-1.s
index 07d0a58ebda..4ecfc6f6ddb 100644
--- a/gas/testsuite/gas/mips/unaligned-jump-micromips-1.s
+++ b/gas/testsuite/gas/mips/unaligned-jump-micromips-1.s
@@ -149,7 +149,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -160,7 +160,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-jump-micromips-2.s b/gas/testsuite/gas/mips/unaligned-jump-micromips-2.s
index 9865f2ebb93..9dff6a1c7f6 100644
--- a/gas/testsuite/gas/mips/unaligned-jump-micromips-2.s
+++ b/gas/testsuite/gas/mips/unaligned-jump-micromips-2.s
@@ -150,7 +150,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -162,7 +162,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-jump-mips16-1.s b/gas/testsuite/gas/mips/unaligned-jump-mips16-1.s
index 329264038b3..bed5ded9522 100644
--- a/gas/testsuite/gas/mips/unaligned-jump-mips16-1.s
+++ b/gas/testsuite/gas/mips/unaligned-jump-mips16-1.s
@@ -85,7 +85,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -96,7 +96,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/gas/testsuite/gas/mips/unaligned-jump-mips16-2.s b/gas/testsuite/gas/mips/unaligned-jump-mips16-2.s
index c2b15aac467..d6dd5ee054c 100644
--- a/gas/testsuite/gas/mips/unaligned-jump-mips16-2.s
+++ b/gas/testsuite/gas/mips/unaligned-jump-mips16-2.s
@@ -86,7 +86,7 @@ bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	obj	\n - 1
+	obj	(\n - 1)
 	.endif
 	.endm
 
@@ -98,7 +98,7 @@ bar\@ :
 	.hword	0
 	.size	bar\@, . - bar\@
 	.if	\n - 1
-	fun	\n - 1
+	fun	(\n - 1)
 	.endif
 	.endm
 
diff --git a/ld/testsuite/ld-mips-elf/unaligned-data.s b/ld/testsuite/ld-mips-elf/unaligned-data.s
index e865a131230..f645c151235 100644
--- a/ld/testsuite/ld-mips-elf/unaligned-data.s
+++ b/ld/testsuite/ld-mips-elf/unaligned-data.s
@@ -5,7 +5,7 @@
 bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
-	sym	\n - 1
+	sym	(\n - 1)
 	.endif
 	.endm
 
diff --git a/ld/testsuite/ld-mips-elf/unaligned-insn.s b/ld/testsuite/ld-mips-elf/unaligned-insn.s
index 10649de9180..5313372caf2 100644
--- a/ld/testsuite/ld-mips-elf/unaligned-insn.s
+++ b/ld/testsuite/ld-mips-elf/unaligned-insn.s
@@ -6,7 +6,7 @@ bar\@ :
 	.insn
 	.hword	0
 	.size	bar\@, . - bar\@
-	sym	\n - 1
+	sym	(\n - 1)
 	.endif
 	.endm
 
diff --git a/ld/testsuite/ld-mips-elf/unaligned-text.s b/ld/testsuite/ld-mips-elf/unaligned-text.s
index 4b3aa38ad9c..2495c4be3e5 100644
--- a/ld/testsuite/ld-mips-elf/unaligned-text.s
+++ b/ld/testsuite/ld-mips-elf/unaligned-text.s
@@ -5,7 +5,7 @@
 bar\@ :
 	.byte	0
 	.size	bar\@, . - bar\@
-	sym	\n - 1
+	sym	(\n - 1)
 	.endif
 	.endm


More information about the Binutils-cvs mailing list