[binutils-gdb] x86: drop unnecessary \() from bundle tests

Jan Beulich jbeulich@sourceware.org
Fri Jul 12 10:29:11 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=246b21d77772d63f8170f3a50ea2814e2be58302

commit 246b21d77772d63f8170f3a50ea2814e2be58302
Author: Jan Beulich <jbeulich@suse.com>
Date:   Fri Jul 12 12:28:50 2024 +0200

    x86: drop unnecessary \() from bundle tests
    
    ':' isn't permitted in macro parameter names, hence this separator
    construct isn't necessary at the end of labels. Drop its use in such
    cases, for being potentially confusing (and hampering readability, even
    if only a little).

Diff:
---
 gas/testsuite/gas/i386/bundle-lock.s   |  2 +-
 gas/testsuite/gas/i386/bundle.s        | 14 +++++++-------
 gas/testsuite/gas/i386/x86-64-bundle.s | 14 +++++++-------
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/gas/testsuite/gas/i386/bundle-lock.s b/gas/testsuite/gas/i386/bundle-lock.s
index af52e995a45..f5a652020ff 100644
--- a/gas/testsuite/gas/i386/bundle-lock.s
+++ b/gas/testsuite/gas/i386/bundle-lock.s
@@ -5,7 +5,7 @@
 
 .macro offset_sequence size, offset
 	.p2align 5
-sequence_\size\()_offset_\offset\():
+sequence_\size\()_offset_\offset:
 	.if \offset
 	.space \offset, 0xf4
 	.endif
diff --git a/gas/testsuite/gas/i386/bundle.s b/gas/testsuite/gas/i386/bundle.s
index 60d9fc5d732..29206384e71 100644
--- a/gas/testsuite/gas/i386/bundle.s
+++ b/gas/testsuite/gas/i386/bundle.s
@@ -5,7 +5,7 @@
 
 .macro offset_insn insn_name, offset
 	.p2align 5
-\insn_name\()_offset_\offset\():
+\insn_name\()_offset_\offset:
 	.if \offset
 	.space \offset, 0xf4
 	.endif
@@ -105,7 +105,7 @@ test_offsets test_12
 .macro jmp_2
 	jmp jmp_2_\@
 	movl $0xdeadbeef,%eax
-jmp_2_\@\():
+jmp_2_\@:
 	movl $0xb00b,%eax
 .endm
 .macro jmp_5
@@ -113,14 +113,14 @@ jmp_2_\@\():
 	.rept 128
 	inc %eax
 	.endr
-jmp_5_\@\():
+jmp_5_\@:
 	movl $0xb00b,%eax
 .endm
 
 .macro cjmp_2
 	jz cjmp_2_\@
 	movl $0xdeadbeef,%eax
-cjmp_2_\@\():
+cjmp_2_\@:
 	movl $0xb00b,%eax
 .endm
 .macro cjmp_6
@@ -128,14 +128,14 @@ cjmp_2_\@\():
 	.rept 128
 	inc %eax
 	.endr
-cjmp_6_\@\():
+cjmp_6_\@:
 	movl $0xb00b,%eax
 .endm
 
 .macro pjmp_3
 	jz,pt pjmp_3_\@
 	movl $0xdeadbeef,%eax
-pjmp_3_\@\():
+pjmp_3_\@:
 	movl $0xb00b,%eax
 .endm
 .macro pjmp_7
@@ -143,7 +143,7 @@ pjmp_3_\@\():
 	.rept 128
 	inc %eax
 	.endr
-pjmp_7_\@\():
+pjmp_7_\@:
 	movl $0xb00b,%eax
 .endm
 
diff --git a/gas/testsuite/gas/i386/x86-64-bundle.s b/gas/testsuite/gas/i386/x86-64-bundle.s
index f8381abbaa6..a4ebb2c83d6 100644
--- a/gas/testsuite/gas/i386/x86-64-bundle.s
+++ b/gas/testsuite/gas/i386/x86-64-bundle.s
@@ -5,7 +5,7 @@
 
 .macro offset_insn insn_name, offset
 	.p2align 5
-\insn_name\()_offset_\offset\():
+\insn_name\()_offset_\offset:
 	.if \offset
 	.space \offset, 0xf4
 	.endif
@@ -109,7 +109,7 @@ test_offsets test_13
 .macro jmp_2
 	jmp jmp_2_\@
 	movl $0xdeadbeef,%eax
-jmp_2_\@\():
+jmp_2_\@:
 	movl $0xb00b,%eax
 .endm
 .macro jmp_5
@@ -117,14 +117,14 @@ jmp_2_\@\():
 	.rept 128
 	clc
 	.endr
-jmp_5_\@\():
+jmp_5_\@:
 	movl $0xb00b,%eax
 .endm
 
 .macro cjmp_2
 	jz cjmp_2_\@
 	movl $0xdeadbeef,%eax
-cjmp_2_\@\():
+cjmp_2_\@:
 	movl $0xb00b,%eax
 .endm
 .macro cjmp_6
@@ -132,14 +132,14 @@ cjmp_2_\@\():
 	.rept 128
 	clc
 	.endr
-cjmp_6_\@\():
+cjmp_6_\@:
 	movl $0xb00b,%eax
 .endm
 
 .macro pjmp_3
 	jz,pt pjmp_3_\@
 	movl $0xdeadbeef,%eax
-pjmp_3_\@\():
+pjmp_3_\@:
 	movl $0xb00b,%eax
 .endm
 .macro pjmp_7
@@ -147,7 +147,7 @@ pjmp_3_\@\():
 	.rept 128
 	clc
 	.endr
-pjmp_7_\@\():
+pjmp_7_\@:
 	movl $0xb00b,%eax
 .endm


More information about the Binutils-cvs mailing list