[binutils-gdb] opcodes: i386-reg.tbl: Add a comment to reflect dependency on ordering

Indu Bhagat ibhagat@sourceware.org
Mon Jan 15 11:38:08 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9f00e4b78e6b7d68ee9a0052a9553472982afc91

commit 9f00e4b78e6b7d68ee9a0052a9553472982afc91
Author: Indu Bhagat <indu.bhagat@oracle.com>
Date:   Mon Jan 15 01:00:42 2024 -0800

    opcodes: i386-reg.tbl: Add a comment to reflect dependency on ordering
    
    The ginsn representation keeps the DWARF register number of the
    operands.  The API ginsn_dw2_regnum relies on the the relative ordering
    of these register entries in the table.  Add a comment to make it clear.
    
    opcodes/
            * i386-reg.tbl: Add a comment.

Diff:
---
 opcodes/i386-reg.tbl | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/opcodes/i386-reg.tbl b/opcodes/i386-reg.tbl
index 5b80ee6026e..f92315392b8 100644
--- a/opcodes/i386-reg.tbl
+++ b/opcodes/i386-reg.tbl
@@ -18,6 +18,9 @@
 // Software Foundation, 51 Franklin Street - Fifth Floor, Boston, MA
 // 02110-1301, USA.
 
+// The code in gas backend for SCFI relies on the relative ordering
+// of 8 bit / 16 bit / 32 bit / 64 bit regs
+
 // 8 bit regs
 al, Class=Reg|Instance=Accum|Byte, 0, 0, Dw2Inval, Dw2Inval
 cl, Class=Reg|Instance=RegC|Byte, 0, 1, Dw2Inval, Dw2Inval


More information about the Binutils-cvs mailing list