[binutils-gdb] PR 14962 testcase xcoff failure

Alan Modra amodra@sourceware.org
Fri Feb 9 02:27:25 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=74f03a0ed2fed504f037711aee75dd1a00d15b17

commit 74f03a0ed2fed504f037711aee75dd1a00d15b17
Author: Alan Modra <amodra@gmail.com>
Date:   Fri Feb 9 12:13:13 2024 +1030

    PR 14962 testcase xcoff failure
    
    Like https://sourceware.org/pipermail/binutils/2002-August/021279.html
    but for symbols defined in an xcoff object but then made absolute by a
    linker script.
    
            * xcofflink.c (xcoff_link_input_bfd): Set n_scnum correctly
            for symbols made absolute by a linker script.

Diff:
---
 bfd/xcofflink.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/bfd/xcofflink.c b/bfd/xcofflink.c
index 6ef9abcd883..49ac8efd1e8 100644
--- a/bfd/xcofflink.c
+++ b/bfd/xcofflink.c
@@ -5482,7 +5482,13 @@ xcoff_link_input_bfd (struct xcoff_final_link_info *flinfo,
 		   && isym.n_sclass != C_DECL
 		   && isym.n_scnum > 0)
 	    {
-	      isym.n_scnum = (*csectpp)->output_section->target_index;
+	      if (*sym_hash != NULL
+		  && ((*sym_hash)->root.type == bfd_link_hash_defined
+		      || (*sym_hash)->root.type == bfd_link_hash_defweak)
+		  && (*sym_hash)->root.u.def.section == bfd_abs_section_ptr)
+		isym.n_scnum = N_ABS;
+	      else
+		isym.n_scnum = (*csectpp)->output_section->target_index;
 	      isym.n_value += ((*csectpp)->output_section->vma
 			       + (*csectpp)->output_offset
 			       - (*csectpp)->vma);


More information about the Binutils-cvs mailing list