[binutils-gdb/binutils-2_43-branch] libctf, subr: don't mix up errors and warnings

Nick Alcock nix@sourceware.org
Thu Aug 1 14:42:30 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e307cadccd0d09128464a774678dbefd5af0a79d

commit e307cadccd0d09128464a774678dbefd5af0a79d
Author: Nick Alcock <nick.alcock@oracle.com>
Date:   Mon Jul 15 21:04:24 2024 +0100

    libctf, subr: don't mix up errors and warnings
    
    ctf_err_warn() was debug-logging warnings as if they were errors and vice
    versa.
    
    libctf/
            * ctf-subr.c (ctf_err_warn): Fix debugging thinko.

Diff:
---
 libctf/ctf-subr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libctf/ctf-subr.c b/libctf/ctf-subr.c
index deb9e0ba5c4..6dbf3e7231a 100644
--- a/libctf/ctf-subr.c
+++ b/libctf/ctf-subr.c
@@ -231,11 +231,11 @@ ctf_err_warn (ctf_dict_t *fp, int is_warning, int err,
      lead to unwinding up to the user.)  */
   if ((!is_warning && (err != 0 || (fp && ctf_errno (fp) != 0)))
       || (is_warning && err != 0))
-    ctf_dprintf ("%s: %s (%s)\n", is_warning ? _("error") : _("warning"),
+    ctf_dprintf ("%s: %s (%s)\n", is_warning ? _("warning") : _("error"),
 		 cew->cew_text, err != 0 ? ctf_errmsg (err)
 		 : ctf_errmsg (ctf_errno (fp)));
   else
-    ctf_dprintf ("%s: %s\n", is_warning ? _("error") : _("warning"),
+    ctf_dprintf ("%s: %s\n", is_warning ? _("warning") : _("error"),
 		 cew->cew_text);
 
   if (fp != NULL)


More information about the Binutils-cvs mailing list