[binutils-gdb] macho-o.c don't leak strtab

Alan Modra amodra@sourceware.org
Wed Jun 21 06:19:56 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9a925d0dad55a3cd4e493642b81c668d2ab09d1d

commit 9a925d0dad55a3cd4e493642b81c668d2ab09d1d
Author: Alan Modra <amodra@gmail.com>
Date:   Wed Jun 21 09:21:54 2023 +0930

    macho-o.c don't leak strtab
    
            * mach-o.c (bfd_mach_o_write_symtab_content): Free strtab on
            success path.

Diff:
---
 bfd/mach-o.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/bfd/mach-o.c b/bfd/mach-o.c
index 55407fa347d..4d414fd95db 100644
--- a/bfd/mach-o.c
+++ b/bfd/mach-o.c
@@ -2073,6 +2073,8 @@ bfd_mach_o_write_symtab_content (bfd *abfd, bfd_mach_o_symtab_command *sym)
   if (!_bfd_stringtab_emit (abfd, strtab))
     goto err;
 
+  _bfd_stringtab_free (strtab);
+
   /* Pad string table.  */
   padlen = bfd_mach_o_pad4 (abfd, sym->strsize);
   if (padlen < 0)


More information about the Binutils-cvs mailing list