[binutils-gdb] Remove BFD_FAIL in cpu-sh.c

Alan Modra amodra@sourceware.org
Thu Jun 1 00:33:19 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d18f60c747c220ef8ca118b61e5db5c5cdf8f28b

commit d18f60c747c220ef8ca118b61e5db5c5cdf8f28b
Author: Alan Modra <amodra@gmail.com>
Date:   Tue May 30 19:46:24 2023 +0930

    Remove BFD_FAIL in cpu-sh.c
    
    The assertions in cpu-sh.c can be triggered by passing bogus values
    in disassemble_info.mach.  This doesn't cause any bfd misbehaviour.
    
            * cpu-sh.c (sh_get_arch_from_bfd_mach): Remove BFD_FAIL.
            (sh_get_arch_up_from_bfd_mach): Likewise.

Diff:
---
 bfd/cpu-sh.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/bfd/cpu-sh.c b/bfd/cpu-sh.c
index afea21a8dac..578ff086c3f 100644
--- a/bfd/cpu-sh.c
+++ b/bfd/cpu-sh.c
@@ -117,9 +117,6 @@ sh_get_arch_from_bfd_mach (unsigned long mach)
     else
       i++;
 
-  /* Machine not found.   */
-  BFD_FAIL();
-
   return SH_ARCH_UNKNOWN_ARCH;
 }
 
@@ -139,9 +136,6 @@ sh_get_arch_up_from_bfd_mach (unsigned long mach)
     else
       i++;
 
-  /* Machine not found.  */
-  BFD_FAIL();
-
   return SH_ARCH_UNKNOWN_ARCH;
 }


More information about the Binutils-cvs mailing list