[binutils-gdb/binutils-2_39-branch] LoongArch: ld: Fix hidden ifunc symbol linker error bug.

liu & zhensong liuzhensong@sourceware.org
Mon Jan 16 01:17:19 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=87cb95ba8c4d86de23b6ba694a126995a17c5fcd

commit 87cb95ba8c4d86de23b6ba694a126995a17c5fcd
Author: mengqinggang <mengqinggang@loongson.cn>
Date:   Mon Jan 9 16:35:26 2023 +0800

    LoongArch: ld: Fix hidden ifunc symbol linker error bug.
    
    For hidden ifunc symbols, it not have GOT entry, only have gotplt entry. When
    process R_LARCH_SOP_PUSH_GPREL, the offset is gotplt entry address minus GOT
    address. When call bfd_put_NN(got->contents + offset), the absolute value of
    offset is grather than got size, and other memory not belonging to GOT is be
    overwritten.
    
    bfd/ChangeLog:
    
            * elfnn-loongarch.c (loongarch_elf_relocate_section): If hidden ifunc
            symbol, don't call bfd_put_NN.

Diff:
---
 bfd/elfnn-loongarch.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
index fafdc7c7458..449fad6d25d 100644
--- a/bfd/elfnn-loongarch.c
+++ b/bfd/elfnn-loongarch.c
@@ -2502,7 +2502,10 @@ loongarch_elf_relocate_section (bfd *output_bfd, struct bfd_link_info *info,
 
 		  if ((off & 1) != 0)
 		    off &= ~1;
-		  else
+		  /* If h has processed (h->got.offset |= 1) or h is hideen
+		     ifunc (h->got.offset == -1), skip it. Hidden ifunc symbol
+		     not has got entry, only has got.plt entry.  */
+		  else if ((h->got.offset & 1) == 0)
 		    {
 		      /* The pr21964-4. Create relocate entry.  */
 		      if (is_pic && h->start_stop)


More information about the Binutils-cvs mailing list