[binutils-gdb] gprofng: fix -Wuse-after-free warning

Vladimir Mezentsev vmezents@sourceware.org
Thu Dec 14 19:15:07 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=01b386b55ecadcfce98896b9214edcd1e6fe0e62

commit 01b386b55ecadcfce98896b9214edcd1e6fe0e62
Author: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
Date:   Wed Dec 13 17:52:15 2023 -0800

    gprofng: fix -Wuse-after-free warning
    
    Removed incorrect unnecessary code.
    
    gprofng/ChangeLog
    2023-12-13  Vladimir Mezentsev  <vladimir.mezentsev@oracle.com>
    
            * src/collctrl.cc (set_synctrace): Fix -Wuse-after-free warning.

Diff:
---
 gprofng/src/collctrl.cc | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gprofng/src/collctrl.cc b/gprofng/src/collctrl.cc
index 5d68b689a64..aeff5a0336c 100644
--- a/gprofng/src/collctrl.cc
+++ b/gprofng/src/collctrl.cc
@@ -1081,10 +1081,6 @@ Coll_Ctrl::set_synctrace (const char *string)
   if (*endchar != 0 || tval < 0)
     {
       free (val);
-      /* invalid setting */
-      /* restore the comma, if it was zeroed out */
-      if (comma_p != NULL)
-	*comma_p = ',';
       return dbe_sprintf (GTXT ("Unrecognized synchronization tracing threshold `%s'\n"), string);
     }
   free (val);


More information about the Binutils-cvs mailing list