[binutils-gdb] Fix adrp distance check

Cary Coutant ccoutant@sourceware.org
Fri Nov 11 00:49:19 GMT 2022


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=cde010e1a866e67b7e895cbcb95dedd3de0a1e56

commit cde010e1a866e67b7e895cbcb95dedd3de0a1e56
Author: Vladislav Khmelevsky <och95@yandex.ru>
Date:   Thu Nov 10 16:46:23 2022 -0800

    Fix adrp distance check
    
    gold/
            * aarch64.cc (aarch64_valid_for_adrp_p): Shift offset
            as a signed number.

Diff:
---
 gold/aarch64.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gold/aarch64.cc b/gold/aarch64.cc
index d1f5c3299b0..c5aa2c710da 100644
--- a/gold/aarch64.cc
+++ b/gold/aarch64.cc
@@ -1182,7 +1182,8 @@ class Reloc_stub : public Stub_base<size, big_endian>
   aarch64_valid_for_adrp_p(AArch64_address location, AArch64_address dest)
   {
     typedef AArch64_relocate_functions<size, big_endian> Reloc;
-    int64_t adrp_imm = (Reloc::Page(dest) - Reloc::Page(location)) >> 12;
+    int64_t adrp_imm = Reloc::Page (dest) - Reloc::Page (location);
+    adrp_imm = adrp_imm < 0 ? ~(~adrp_imm >> 12) : adrp_imm >> 12;
     return adrp_imm >= MIN_ADRP_IMM && adrp_imm <= MAX_ADRP_IMM;
   }


More information about the Binutils-cvs mailing list