[binutils-gdb] Don't use C++ comments in assembly

Alan Modra amodra@sourceware.org
Thu Jan 13 03:43:26 GMT 2022


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=dd68e156fdeee13046b31b002abcee018269e4c2

commit dd68e156fdeee13046b31b002abcee018269e4c2
Author: Alan Modra <amodra@gmail.com>
Date:   Thu Jan 13 12:15:45 2022 +1030

    Don't use C++ comments in assembly
    
    It might seem to work, but only if '/' is a start of comment char.
    
            * testsuite/ld-elf/dt-relr-1.s: Use # for comment.
            * testsuite/ld-elf/dt-relr-2.s: Likewise.
            * testsuite/ld-elf/dt-relr-3.s: Likewise.

Diff:
---
 ld/testsuite/ld-elf/dt-relr-1.s | 2 +-
 ld/testsuite/ld-elf/dt-relr-2.s | 2 +-
 ld/testsuite/ld-elf/dt-relr-3.s | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ld/testsuite/ld-elf/dt-relr-1.s b/ld/testsuite/ld-elf/dt-relr-1.s
index 1eb34588160..ce1a876b1e8 100644
--- a/ld/testsuite/ld-elf/dt-relr-1.s
+++ b/ld/testsuite/ld-elf/dt-relr-1.s
@@ -9,5 +9,5 @@ _start:
 	.globl data
 data:
 	.byte 0
-	// Offset is not a multiple of 2.  Don't use DT_RELR.
+# Offset is not a multiple of 2.  Don't use DT_RELR.
 	.dc.a __ehdr_start + 10
diff --git a/ld/testsuite/ld-elf/dt-relr-2.s b/ld/testsuite/ld-elf/dt-relr-2.s
index bd1f3dfa16f..1fcee6c6fce 100644
--- a/ld/testsuite/ld-elf/dt-relr-2.s
+++ b/ld/testsuite/ld-elf/dt-relr-2.s
@@ -16,5 +16,5 @@ data:
 	.dc.a __ehdr_start + 9
 
 	.byte 0
-	// Offset is not a multiple of 2.  Don't use DT_RELR.
+# Offset is not a multiple of 2.  Don't use DT_RELR.
 	.dc.a __ehdr_start + 10
diff --git a/ld/testsuite/ld-elf/dt-relr-3.s b/ld/testsuite/ld-elf/dt-relr-3.s
index d020132466f..41ea08ec28c 100644
--- a/ld/testsuite/ld-elf/dt-relr-3.s
+++ b/ld/testsuite/ld-elf/dt-relr-3.s
@@ -4,7 +4,7 @@
 _start:
 	.byte 0
 
-	// Section alignment is not a multiple of 2.  Don't use DT_RELR.
+# Section alignment is not a multiple of 2.  Don't use DT_RELR.
 	.data
 	.p2align 0
 	.globl data


More information about the Binutils-cvs mailing list