[binutils-gdb] RISC-V: Remove a loop in the ISA parser

Nelson Chu nelsonc1225@sourceware.org
Fri Feb 25 09:07:26 GMT 2022


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0f94906fba909f75cb00402caad8e37be92f9c6f

commit 0f94906fba909f75cb00402caad8e37be92f9c6f
Author: Tsukasa OI <research_trasio@irq.a4lg.com>
Date:   Wed Feb 23 10:47:22 2022 +0900

    RISC-V: Remove a loop in the ISA parser
    
    Since commit e601909a3287bf541c6a7d82214bb387d2c76d82 ("RISC-V: Support
    to parse the multi-letter prefix in the architecture string.") changed
    so that all prefixed extensions are parsed in single
    riscv_parse_prefixed_ext call, a "while" loop on riscv_parse_subset
    is no longer required.
    
    bfd/ChangeLog:
    
            * elfxx-riscv.c (riscv_parse_subset): Remove unnecessary loop.

Diff:
---
 bfd/elfxx-riscv.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c
index d74e7a584eb..2915b74dd0f 100644
--- a/bfd/elfxx-riscv.c
+++ b/bfd/elfxx-riscv.c
@@ -2019,14 +2019,11 @@ riscv_parse_subset (riscv_parse_subset_t *rps,
   if (p == NULL)
     return false;
 
-  /* Parse the different classes of extensions in the specified order.  */
-  while (*p != '\0')
-    {
-      p = riscv_parse_prefixed_ext (rps, arch, p);
+  /* Parse prefixed extensions.  */
+  p = riscv_parse_prefixed_ext (rps, arch, p);
 
-      if (p == NULL)
-        return false;
-    }
+  if (p == NULL)
+    return false;
 
   /* Finally add implicit extensions according to the current
      extensions.  */


More information about the Binutils-cvs mailing list