[binutils-gdb] bfd: add translation wrappers to PE image section RVA diagnostics

Jan Beulich jbeulich@sourceware.org
Mon Mar 22 07:23:50 GMT 2021


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2aaf2ce843e4078b158cdfb61435217621ba1803

commit 2aaf2ce843e4078b158cdfb61435217621ba1803
Author: Jan Beulich <jbeulich@suse.com>
Date:   Mon Mar 22 08:23:42 2021 +0100

    bfd: add translation wrappers to PE image section RVA diagnostics
    
    In commit 87fa7d568ddd ("bfd: don't silently wrap or truncate PE image
    section RVAs") I forgot about the need to wrap string literals for
    translation.

Diff:
---
 bfd/ChangeLog  | 6 ++++++
 bfd/peXXigen.c | 4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index bb273426eb3..6cdf3acc556 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2021-03-22  Jan Beulich  <jbeulich@suse.com>
+
+	* peXXigen.c (_bfd_XXi_swap_scnhdr_out): Add missing
+	language translation wrapping to _bfd_error_handler()
+	invocations.
+
 2021-03-21  Alan Modra  <amodra@gmail.com>
 
 	* bfd-in.h (startswith): New inline.
diff --git a/bfd/peXXigen.c b/bfd/peXXigen.c
index b3706723c83..14daf4f6e57 100644
--- a/bfd/peXXigen.c
+++ b/bfd/peXXigen.c
@@ -935,10 +935,10 @@ _bfd_XXi_swap_scnhdr_out (bfd * abfd, void * in, void * out)
 
   ss = scnhdr_int->s_vaddr - pe_data (abfd)->pe_opthdr.ImageBase;
   if (scnhdr_int->s_vaddr < pe_data (abfd)->pe_opthdr.ImageBase)
-    _bfd_error_handler ("%pB:%.8s: section below image base",
+    _bfd_error_handler (_("%pB:%.8s: section below image base"),
                         abfd, scnhdr_int->s_name);
   else if(ss != (ss & 0xffffffff))
-    _bfd_error_handler ("%pB:%.8s: RVA truncated", abfd, scnhdr_int->s_name);
+    _bfd_error_handler (_("%pB:%.8s: RVA truncated"), abfd, scnhdr_int->s_name);
   PUT_SCNHDR_VADDR (abfd, ss & 0xffffffff, scnhdr_ext->s_vaddr);
 
   /* NT wants the size data to be rounded up to the next


More information about the Binutils-cvs mailing list