[binutils-gdb] binutils fails to compile on AIX due to mismatched declaration

[Alan Modra]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0b7733b665333107502223bde3f7823cdc09c947

commit 0b7733b665333107502223bde3f7823cdc09c947
Author: Alan Modra <amodra@gmail.com>
Date:   Thu Mar 4 08:46:22 2021 +1030

    binutils fails to compile on AIX due to mismatched declaration
    
    rs6000-core.c:280:19: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
     const bfd_cleanup rs6000coff_core_p (bfd *abfd);
                       ^~~~~~~~~~~~~~~~~
    rs6000-core.c:336:1: error: conflicting types for 'rs6000coff_core_p'
     rs6000coff_core_p (bfd *abfd)
     ^~~~~~~~~~~~~~~~~
    rs6000-core.c:280:19: note: previous declaration of 'rs6000coff_core_p' was here
     const bfd_cleanup rs6000coff_core_p (bfd *abfd);
                       ^~~~~~~~~~~~~~~~~
    
            * rs6000-core.c (rs6000coff_core_p): Correct prototype.

Diff:
---
 bfd/ChangeLog     | 4 ++++
 bfd/rs6000-core.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 5e2571bf347..af09b0008a8 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,7 @@
+2021-03-04  Alan Modra  <amodra@gmail.com>
+
+	* rs6000-core.c (rs6000coff_core_p): Correct prototype.
+
 2021-03-03  Alan Modra  <amodra@gmail.com>
 
 	PR 27500
diff --git a/bfd/rs6000-core.c b/bfd/rs6000-core.c
index 9fed1ff48b3..1c19060a5d9 100644
--- a/bfd/rs6000-core.c
+++ b/bfd/rs6000-core.c
@@ -277,7 +277,7 @@ typedef union
 /* Define prototypes for certain functions, to avoid a compiler warning
    saying that they are missing.  */
 
-const bfd_cleanup rs6000coff_core_p (bfd *abfd);
+bfd_cleanup rs6000coff_core_p (bfd *abfd);
 bfd_boolean rs6000coff_core_file_matches_executable_p (bfd *core_bfd,
 						       bfd *exec_bfd);
 char * rs6000coff_core_file_failing_command (bfd *abfd);