[binutils-gdb] When displaying ARM private file flag bits, use a 0x prefix.

Nick Clifton nickc@sourceware.org
Mon Jan 4 15:15:06 GMT 2021


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=dbb078f66ecfe2d50fd3e03463b5b206a8eed243

commit dbb078f66ecfe2d50fd3e03463b5b206a8eed243
Author: Alexander Fedotov <alfedotov@gmail.com>
Date:   Mon Jan 4 15:13:57 2021 +0000

    When displaying ARM private file flag bits, use a 0x prefix.
    
            * elf32-arm.c (elf32_arm_print_private_bfd_data): Prefix hex value
            of private flags with 0x.
            * elfnn-aarch64.c (elfNN_aarch64_print_private_bfd_data): Likewise.

Diff:
---
 bfd/ChangeLog       | 6 ++++++
 bfd/elf32-arm.c     | 4 ++--
 bfd/elfnn-aarch64.c | 4 ++--
 3 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 0a472e5ce2d..df9cb205012 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2021-01-04  Alexander Fedotov  <alfedotov@gmail.com>
+
+	* elf32-arm.c (elf32_arm_print_private_bfd_data): Prefix hex value
+	of private flags with 0x.
+	* elfnn-aarch64.c (elfNN_aarch64_print_private_bfd_data): Likewise.
+
 2021-01-04  Alan Modra  <amodra@gmail.com>
 
 	PR 26822
diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
index 818d06e6b6e..d23f6c07e08 100644
--- a/bfd/elf32-arm.c
+++ b/bfd/elf32-arm.c
@@ -15062,7 +15062,7 @@ elf32_arm_print_private_bfd_data (bfd *abfd, void * ptr)
   /* Ignore init flag - it may not be set, despite the flags field
      containing valid data.  */
 
-  fprintf (file, _("private flags = %lx:"), elf_elfheader (abfd)->e_flags);
+  fprintf (file, _("private flags = 0x%lx:"), elf_elfheader (abfd)->e_flags);
 
   switch (EF_ARM_EABI_VERSION (flags))
     {
@@ -15183,7 +15183,7 @@ elf32_arm_print_private_bfd_data (bfd *abfd, void * ptr)
   flags &= ~ (EF_ARM_RELEXEC | EF_ARM_PIC);
 
   if (flags)
-    fprintf (file, _("<Unrecognised flag bits set>"));
+    fprintf (file, _(" <Unrecognised flag bits set>"));
 
   fputc ('\n', file);
 
diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
index 7e4fdd92963..1ec405ef1e0 100644
--- a/bfd/elfnn-aarch64.c
+++ b/bfd/elfnn-aarch64.c
@@ -7331,10 +7331,10 @@ elfNN_aarch64_print_private_bfd_data (bfd *abfd, void *ptr)
      containing valid data.  */
 
   /* xgettext:c-format */
-  fprintf (file, _("private flags = %lx:"), elf_elfheader (abfd)->e_flags);
+  fprintf (file, _("private flags = 0x%lx:"), elf_elfheader (abfd)->e_flags);
 
   if (flags)
-    fprintf (file, _("<Unrecognised flag bits set>"));
+    fprintf (file, _(" <Unrecognised flag bits set>"));
 
   fputc ('\n', file);


More information about the Binutils-cvs mailing list