[binutils-gdb] rx-dis.c:103:3: suspicious concatenation of string literals

Alan Modra amodra@sourceware.org
Mon Sep 21 08:58:25 GMT 2020


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c73eac969a8e14ebc5e3a1671951368728d01066

commit c73eac969a8e14ebc5e3a1671951368728d01066
Author: Alan Modra <amodra@gmail.com>
Date:   Mon Sep 21 18:20:58 2020 +0930

    rx-dis.c:103:3: suspicious concatenation of string literals
    
            * rx-dis.c (flag_names): Add missing comma.
            (register_names, flag_names, double_register_names),
            (double_register_high_names, double_register_low_names),
            (double_control_register_names, double_condition_names): Remove
            trailing commas.

Diff:
---
 opcodes/ChangeLog |  8 ++++++++
 opcodes/rx-dis.c  | 16 ++++++++--------
 2 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 0f3c270810c..58b0905e772 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,11 @@
+2020-09-21  Alan Modra  <amodra@gmail.com>
+
+	* rx-dis.c (flag_names): Add missing comma.
+	(register_names, flag_names, double_register_names),
+	(double_register_high_names, double_register_low_names),
+	(double_control_register_names, double_condition_names): Remove
+	trailing commas.
+
 2020-09-18  David Faust  <david.faust@oracle.com>
 
 	* bpf-desc.c: Regenerate.
diff --git a/opcodes/rx-dis.c b/opcodes/rx-dis.c
index 29ba71c1215..1e5591ca983 100644
--- a/opcodes/rx-dis.c
+++ b/opcodes/rx-dis.c
@@ -85,7 +85,7 @@ static char const * register_names[] =
   "psw", "pc", "usp", "fpsw", NULL, NULL, NULL, NULL,
   "bpsw", "bpc", "isp", "fintv", "intb", "extb", NULL, NULL,
   "a0", "a1", NULL, NULL, NULL, NULL, NULL, NULL,
-  NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+  NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL
 };
 
 static char const * condition_names[] =
@@ -99,36 +99,36 @@ static const char * flag_names[] =
 {
   "c", "z", "s", "o", "", "", "", "",
   "", "", "", "", "", "", "", "",
-  "i", "u", "", "", "", "", "", ""
-  "", "", "", "", "", "", "", "",
+  "i", "u", "", "", "", "", "", "",
+  "", "", "", "", "", "", "", ""
 };
 
 static const char * double_register_names[] =
 {
   "dr0", "dr1", "dr2", "dr3", "dr4", "dr5", "dr6", "dr7",
-  "dr8", "dr9", "dr10", "dr11", "dr12", "dr13", "dr14", "dr15",
+  "dr8", "dr9", "dr10", "dr11", "dr12", "dr13", "dr14", "dr15"
 };
 
 static const char * double_register_high_names[] =
 {
   "drh0", "drh1", "drh2", "drh3", "drh4", "drh5", "drh6", "drh7",
-  "drh8", "drh9", "drh10", "drh11", "drh12", "drh13", "drh14", "drh15",
+  "drh8", "drh9", "drh10", "drh11", "drh12", "drh13", "drh14", "drh15"
 };
 
 static const char * double_register_low_names[] =
 {
   "drl0", "drl1", "drl2", "drl3", "drl4", "drl5", "drl6", "drl7",
-  "drl8", "drl9", "drl10", "drl11", "drl12", "drl13", "drl14", "drl15",
+  "drl8", "drl9", "drl10", "drl11", "drl12", "drl13", "drl14", "drl15"
 };
 
 static const char * double_control_register_names[] =
 {
-  "dpsw", "dcmr", "decnt", "depc",
+  "dpsw", "dcmr", "decnt", "depc"
 };
 
 static const char * double_condition_names[] =
 {
-  "", "un", "eq", "", "lt", "", "le",
+  "", "un", "eq", "", "lt", "", "le"
 };
 
 static inline const char *


More information about the Binutils-cvs mailing list