[binutils-gdb] PR26936 testsuite fixes

Alan Modra amodra@sourceware.org
Thu Nov 26 08:10:35 GMT 2020


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9ed0136bff648c2f32d7462d3ab9205b61778837

commit 9ed0136bff648c2f32d7462d3ab9205b61778837
Author: Alan Modra <amodra@gmail.com>
Date:   Thu Nov 26 17:45:26 2020 +1030

    PR26936 testsuite fixes
    
    Many targets fail this test due to -z noseparate-code not being
    supported, or _start not being the proper entry symbol, or "as -g"
    something other than "generate debug".
    
            PR 26936
            * testsuite/ld-elf/pr26936.d: Pass --gen-debug to gas rather than -g.
            Only run when -shared -z options are supported.
            * testsuite/ld-elf/pr26936b.s: Define more entry symbols.

Diff:
---
 ld/ChangeLog                   |  7 +++++++
 ld/testsuite/ld-elf/pr26936.d  |  3 ++-
 ld/testsuite/ld-elf/pr26936b.s | 16 ++++++++++++++--
 3 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/ld/ChangeLog b/ld/ChangeLog
index 005d54e80da..fb831d997bb 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,10 @@
+2020-11-26  Alan Modra  <amodra@gmail.com>
+
+	PR 26936
+	* testsuite/ld-elf/pr26936.d: Pass --gen-debug to gas rather than -g.
+	Only run when -shared -z options are supported.
+	* testsuite/ld-elf/pr26936b.s: Define more entry symbols.
+
 2020-11-25  H.J. Lu  <hongjiu.lu@intel.com>
 
 	PR ld/26936
diff --git a/ld/testsuite/ld-elf/pr26936.d b/ld/testsuite/ld-elf/pr26936.d
index b007e83ff20..3c854fa0b5c 100644
--- a/ld/testsuite/ld-elf/pr26936.d
+++ b/ld/testsuite/ld-elf/pr26936.d
@@ -1,9 +1,10 @@
 #source: pr26936a.s
 #source: pr26936b.s
 #source: pr26936c.s
-#as: -g
+#as: --gen-debug
 #ld: -z noseparate-code -Ttext-segment 0x10000 -z max-page-size=0x1000
 #readelf: -wL
+#target: [check_shared_lib_support]
 
 #...
 CU: .*/pr26936c.s:
diff --git a/ld/testsuite/ld-elf/pr26936b.s b/ld/testsuite/ld-elf/pr26936b.s
index 433528c33e9..6ce9fd04417 100644
--- a/ld/testsuite/ld-elf/pr26936b.s
+++ b/ld/testsuite/ld-elf/pr26936b.s
@@ -1,7 +1,19 @@
 	.text
-	.globl _start
+	.type start,"function"
+	.global start
+start:
+	.type _start,"function"
+	.global _start
 _start:
-	.type   _start, %function
+	.type __start,"function"
+	.global __start
+__start:
+	.type main,"function"
+	.global main
+main:
+	.type _main,"function"
+	.global _main
+_main:
 	.nop
 	.section .text.__x86.get_pc_thunk.bx,"axG",%progbits,__x86.get_pc_thunk.bx,comdat
 	.globl  __x86.get_pc_thunk.bx


More information about the Binutils-cvs mailing list