[binutils-gdb] alpha-coff: unitialised read

[Alan Modra]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=89b599df37111317b9bc6fab541eb94c8b0bea35

commit 89b599df37111317b9bc6fab541eb94c8b0bea35
Author: Alan Modra <amodra@gmail.com>
Date:   Tue Mar 31 15:01:01 2020 +1030

    alpha-coff: unitialised read
    
            * coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Correct bfd_bread
            return value check.

Diff:
---
 bfd/ChangeLog    | 5 +++++
 bfd/coff-alpha.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 1878fd79716..4c2bb14f6cc 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2020-03-31  Alan Modra  <amodra@gmail.com>
+
+	* coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Correct bfd_bread
+	return value check.
+
 2020-03-31  Alan Modra  <amodra@gmail.com>
 
 	* vms-alpha.c (image_write): Check bounds for sections without
diff --git a/bfd/coff-alpha.c b/bfd/coff-alpha.c
index b86a8a259b5..4fd3b5c488d 100644
--- a/bfd/coff-alpha.c
+++ b/bfd/coff-alpha.c
@@ -2130,7 +2130,7 @@ alpha_ecoff_get_elt_at_filepos (bfd *archive, file_ptr filepos)
 		n = dict[h];
 	      else
 		{
-		  if (! bfd_bread (&n, (bfd_size_type) 1, nbfd))
+		  if (bfd_bread (&n, 1, nbfd) != 1)
 		    goto error_return;
 		  dict[h] = n;
 		}