[binutils-gdb] ubsan: som: left shift of 1 by 31 places

Alan Modra amodra@sourceware.org
Tue Mar 10 11:35:27 GMT 2020


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e10ac147c80240c2d0aa0a2ae2ec7f6a934c198f

commit e10ac147c80240c2d0aa0a2ae2ec7f6a934c198f
Author: Alan Modra <amodra@gmail.com>
Date:   Tue Mar 10 17:52:01 2020 +1030

    ubsan: som: left shift of 1 by 31 places
    
            * som/aout.h (SOM_AUX_ID_MANDATORY, SOM_SPACE_IS_LOADABLE),
            (SOM_SYMBOL_HIDDEN, SOM_SYMBOL_HAS_LONG_RETURN): Use 1u << 31.
            * som/lst.h (LST_SYMBOL_HIDDEN): Likewise.

Diff:
---
 include/ChangeLog  | 6 ++++++
 include/som/aout.h | 8 ++++----
 include/som/lst.h  | 2 +-
 3 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/include/ChangeLog b/include/ChangeLog
index 8659ef4daf0..ad0ad9add65 100644
--- a/include/ChangeLog
+++ b/include/ChangeLog
@@ -1,3 +1,9 @@
+2020-03-10  Alan Modra  <amodra@gmail.com>
+
+	* som/aout.h (SOM_AUX_ID_MANDATORY, SOM_SPACE_IS_LOADABLE),
+	(SOM_SYMBOL_HIDDEN, SOM_SYMBOL_HAS_LONG_RETURN): Use 1u << 31.
+	* som/lst.h (LST_SYMBOL_HIDDEN): Likewise.
+
 2020-03-03  Luis Machado  <luis.machado@linaro.org>
 
 	* elf/common.h (AT_L1I_CACHESIZE, AT_L1I_CACHEGEOMETRY)
diff --git a/include/som/aout.h b/include/som/aout.h
index 618f09dcc9a..01b301fe01c 100644
--- a/include/som/aout.h
+++ b/include/som/aout.h
@@ -86,7 +86,7 @@ struct som_external_aux_id
 #define COPYRIGHT_AUX_ID 9
 
 /* Aux id flags.  */
-#define SOM_AUX_ID_MANDATORY	(1 << 31)
+#define SOM_AUX_ID_MANDATORY	(1u << 31)
 #define SOM_AUX_ID_COPY		(1 << 30)
 #define SOM_AUX_ID_APPEND	(1 << 29)
 #define SOM_AUX_ID_IGNORE	(1 << 28)
@@ -134,7 +134,7 @@ struct som_external_space_dictionary_record
   unsigned char init_pointer_quantity[4];
 };
 
-#define SOM_SPACE_IS_LOADABLE		(1 << 31)
+#define SOM_SPACE_IS_LOADABLE		(1u << 31)
 #define SOM_SPACE_IS_DEFINED		(1 << 30)
 #define SOM_SPACE_IS_PRIVATE		(1 << 29)
 #define SOM_SPACE_HAS_INTERMEDIATE_CODE (1 << 28)
@@ -195,7 +195,7 @@ struct som_external_symbol_dictionary_record
 };
 
 /* Flags fields.  */
-#define SOM_SYMBOL_HIDDEN (1 << 31)
+#define SOM_SYMBOL_HIDDEN (1u << 31)
 #define SOM_SYMBOL_SECONDARY_DEF (1 << 30)
 #define SOM_SYMBOL_TYPE_SH 24
 #define SOM_SYMBOL_TYPE_MASK 0x3f
@@ -214,7 +214,7 @@ struct som_external_symbol_dictionary_record
 #define SOM_SYMBOL_ARG_RELOC_MASK 0x3ff
 
 /* Info fields.  */
-#define SOM_SYMBOL_HAS_LONG_RETURN (1 << 31)
+#define SOM_SYMBOL_HAS_LONG_RETURN (1u << 31)
 #define SOM_SYMBOL_NO_RELOCATION (1 << 30)
 #define SOM_SYMBOL_IS_COMDAT (1 << 29)
 #define SOM_SYMBOL_SYMBOL_INFO_SH 0
diff --git a/include/som/lst.h b/include/som/lst.h
index f97237ffe97..014fc7a89a2 100644
--- a/include/som/lst.h
+++ b/include/som/lst.h
@@ -69,7 +69,7 @@ struct som_external_lst_symbol_record
 };
 
 /* Fields of flags.  */
-#define LST_SYMBOL_HIDDEN		(1 << 31)
+#define LST_SYMBOL_HIDDEN		(1u << 31)
 #define LST_SYMBOL_SECONDARY_DEF	(1 << 30)
 #define LST_SYMBOL_SYMBOL_TYPE_SH	24
 #define LST_SYMBOL_SYMBOL_SCOPE_SH	20


More information about the Binutils-cvs mailing list