[binutils-gdb] Ensure *valuep always written by extract_normal return
Alan Modra
amodra@sourceware.org
Tue Feb 11 02:49:00 GMT 2020
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2f5dd314d60e25b3094694999889c72a49fee76b
commit 2f5dd314d60e25b3094694999889c72a49fee76b
Author: Alan Modra <amodra@gmail.com>
Date: Tue Feb 11 09:11:18 2020 +1030
Ensure *valuep always written by extract_normal return
* cgen-ibld.in (extract_normal): Set *valuep on all return paths.
* bpf-ibld.c, * epiphany-ibld.c, * fr30-ibld.c, * frv-ibld.c,
* ip2k-ibld.c, * iq2000-ibld.c, * lm32-ibld.c, * m32c-ibld.c,
* m32r-ibld.c, * mep-ibld.c, * mt-ibld.c, * or1k-ibld.c,
* xc16x-ibld.c, * xstormy16-ibld.c: Regenerate.
Diff:
---
opcodes/ChangeLog | 8 ++++++++
opcodes/bpf-ibld.c | 5 ++++-
opcodes/cgen-ibld.in | 5 ++++-
opcodes/epiphany-ibld.c | 5 ++++-
opcodes/fr30-ibld.c | 5 ++++-
opcodes/frv-ibld.c | 5 ++++-
opcodes/ip2k-ibld.c | 5 ++++-
opcodes/iq2000-ibld.c | 5 ++++-
opcodes/lm32-ibld.c | 5 ++++-
opcodes/m32c-ibld.c | 5 ++++-
opcodes/m32r-ibld.c | 5 ++++-
opcodes/mep-ibld.c | 5 ++++-
opcodes/mt-ibld.c | 5 ++++-
opcodes/or1k-ibld.c | 5 ++++-
opcodes/xc16x-ibld.c | 5 ++++-
opcodes/xstormy16-ibld.c | 5 ++++-
16 files changed, 68 insertions(+), 15 deletions(-)
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 7ab3a81..1e02056 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,11 @@
+2020-02-11 Alan Modra <amodra@gmail.com>
+
+ * cgen-ibld.in (extract_normal): Set *valuep on all return paths.
+ * bpf-ibld.c, * epiphany-ibld.c, * fr30-ibld.c, * frv-ibld.c,
+ * ip2k-ibld.c, * iq2000-ibld.c, * lm32-ibld.c, * m32c-ibld.c,
+ * m32r-ibld.c, * mep-ibld.c, * mt-ibld.c, * or1k-ibld.c,
+ * xc16x-ibld.c, * xstormy16-ibld.c: Regenerate.
+
2020-02-10 Matthew Malcomson <matthew.malcomson@arm.com>
* arm-dis.c (print_insn_cde): Define 'V' parse character.
diff --git a/opcodes/bpf-ibld.c b/opcodes/bpf-ibld.c
index 8b73f2f..d5fa57a 100644
--- a/opcodes/bpf-ibld.c
+++ b/opcodes/bpf-ibld.c
@@ -480,7 +480,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
diff --git a/opcodes/cgen-ibld.in b/opcodes/cgen-ibld.in
index 9d856cd..6a9b97f 100644
--- a/opcodes/cgen-ibld.in
+++ b/opcodes/cgen-ibld.in
@@ -479,7 +479,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
diff --git a/opcodes/epiphany-ibld.c b/opcodes/epiphany-ibld.c
index 64b3d38..c23a969 100644
--- a/opcodes/epiphany-ibld.c
+++ b/opcodes/epiphany-ibld.c
@@ -480,7 +480,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
diff --git a/opcodes/fr30-ibld.c b/opcodes/fr30-ibld.c
index ea4ea0a..5544d55 100644
--- a/opcodes/fr30-ibld.c
+++ b/opcodes/fr30-ibld.c
@@ -480,7 +480,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
diff --git a/opcodes/frv-ibld.c b/opcodes/frv-ibld.c
index 5e31df2..0421884 100644
--- a/opcodes/frv-ibld.c
+++ b/opcodes/frv-ibld.c
@@ -480,7 +480,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
diff --git a/opcodes/ip2k-ibld.c b/opcodes/ip2k-ibld.c
index a7dd80c..9258f7d 100644
--- a/opcodes/ip2k-ibld.c
+++ b/opcodes/ip2k-ibld.c
@@ -480,7 +480,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
diff --git a/opcodes/iq2000-ibld.c b/opcodes/iq2000-ibld.c
index 1e5cc47..319e994 100644
--- a/opcodes/iq2000-ibld.c
+++ b/opcodes/iq2000-ibld.c
@@ -480,7 +480,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
diff --git a/opcodes/lm32-ibld.c b/opcodes/lm32-ibld.c
index 0a5e54a..9b594e8 100644
--- a/opcodes/lm32-ibld.c
+++ b/opcodes/lm32-ibld.c
@@ -480,7 +480,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
diff --git a/opcodes/m32c-ibld.c b/opcodes/m32c-ibld.c
index 36231f2..c1fca2e 100644
--- a/opcodes/m32c-ibld.c
+++ b/opcodes/m32c-ibld.c
@@ -480,7 +480,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
diff --git a/opcodes/m32r-ibld.c b/opcodes/m32r-ibld.c
index 8d5ce60..ddebc32 100644
--- a/opcodes/m32r-ibld.c
+++ b/opcodes/m32r-ibld.c
@@ -480,7 +480,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
diff --git a/opcodes/mep-ibld.c b/opcodes/mep-ibld.c
index c1d2e39..6a73f41 100644
--- a/opcodes/mep-ibld.c
+++ b/opcodes/mep-ibld.c
@@ -480,7 +480,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
diff --git a/opcodes/mt-ibld.c b/opcodes/mt-ibld.c
index 92dc6bc..53a0775 100644
--- a/opcodes/mt-ibld.c
+++ b/opcodes/mt-ibld.c
@@ -480,7 +480,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
diff --git a/opcodes/or1k-ibld.c b/opcodes/or1k-ibld.c
index cc2955f..d802a98 100644
--- a/opcodes/or1k-ibld.c
+++ b/opcodes/or1k-ibld.c
@@ -480,7 +480,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
diff --git a/opcodes/xc16x-ibld.c b/opcodes/xc16x-ibld.c
index 5929ded..6b228bc 100644
--- a/opcodes/xc16x-ibld.c
+++ b/opcodes/xc16x-ibld.c
@@ -480,7 +480,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
diff --git a/opcodes/xstormy16-ibld.c b/opcodes/xstormy16-ibld.c
index 69555cb..70cf88d 100644
--- a/opcodes/xstormy16-ibld.c
+++ b/opcodes/xstormy16-ibld.c
@@ -480,7 +480,10 @@ extract_normal (CGEN_CPU_DESC cd,
abort ();
if (fill_cache (cd, ex_info, word_offset / 8, word_length / 8, pc) == 0)
- return 0;
+ {
+ *valuep = 0;
+ return 0;
+ }
value = extract_1 (cd, ex_info, start, length, word_length, bufp, pc);
}
More information about the Binutils-cvs
mailing list