[binutils-gdb] Re: commit eae0b5c3b2d6b

[Alan Modra]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c415c83bd98e683d2be0709f476315d46906a371

commit c415c83bd98e683d2be0709f476315d46906a371
Author: Alan Modra <amodra@gmail.com>
Date:   Thu Aug 27 21:54:16 2020 +0930

    Re: commit eae0b5c3b2d6b
    
            PR 26416
            * elf64-alpha.c (elf64_alpha_relax_tls_get_addr): Correct "dynamic".

Diff:
---
 bfd/ChangeLog     | 5 +++++
 bfd/elf64-alpha.c | 5 ++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 646036483a9..fb998c24986 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2020-08-27  Alan Modra  <amodra@gmail.com>
+
+	PR 26416
+	* elf64-alpha.c (elf64_alpha_relax_tls_get_addr): Correct "dynamic".
+
 2020-08-26  Nick Clifton  <nickc@redhat.com>
 
 	PR 26433
diff --git a/bfd/elf64-alpha.c b/bfd/elf64-alpha.c
index fd1f4b20be1..7b708f1e9d9 100644
--- a/bfd/elf64-alpha.c
+++ b/bfd/elf64-alpha.c
@@ -3464,9 +3464,8 @@ elf64_alpha_relax_tls_get_addr (struct alpha_relax_info *info, bfd_vma symval,
   bfd_boolean dynamic, use_gottprel;
   unsigned long new_symndx;
 
-  if (info->h == NULL)
-    return TRUE; /* FIXME: Should this be return FALSE ?  */
-  dynamic = alpha_elf_dynamic_symbol_p (&info->h->root, info->link_info);
+  dynamic = (info->h != NULL
+	     && alpha_elf_dynamic_symbol_p (&info->h->root, info->link_info));
 
   /* If a TLS symbol is accessed using IE at least once, there is no point
      to use dynamic model for it.  */