[binutils-gdb] coff bfd.h tidy

Alan Modra amodra@sourceware.org
Mon Sep 23 00:58:00 GMT 2019


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=aa739c59d3db95d1709b0417cdf7d082bfdea911

commit aa739c59d3db95d1709b0417cdf7d082bfdea911
Author: Alan Modra <amodra@gmail.com>
Date:   Mon Sep 23 10:07:40 2019 +0930

    coff bfd.h tidy
    
    bfd/
    	* bfd-in.h: Delete coff forward refs and move coff declaration..
    	* coff-bfd.h: ..to here.
    	* bfd-in2.h: Regenerate.
    binutils/
    	* dlltool.c: Include coff-bfd.h.

Diff:
---
 bfd/ChangeLog      |  6 ++++++
 bfd/bfd-in.h       | 10 ----------
 bfd/bfd-in2.h      | 10 ----------
 bfd/coff-bfd.h     |  3 +++
 binutils/ChangeLog |  4 ++++
 binutils/dlltool.c |  1 +
 6 files changed, 14 insertions(+), 20 deletions(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index c1f82cd..696eeac 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,5 +1,11 @@
 2019-09-23  Alan Modra  <amodra@gmail.com>
 
+	* bfd-in.h: Delete coff forward refs and move coff declaration..
+	* coff-bfd.h: ..to here.
+	* bfd-in2.h: Regenerate.
+
+2019-09-23  Alan Modra  <amodra@gmail.com>
+
 	* bfd-in.h: Move arm declaraions..
 	* cpu-arm.h: ..to here, new file..
 	* coff-arm.h: ..and here, new file..
diff --git a/bfd/bfd-in.h b/bfd/bfd-in.h
index 124a0c2..a629a84 100644
--- a/bfd/bfd-in.h
+++ b/bfd/bfd-in.h
@@ -753,13 +753,3 @@ extern bfd_boolean bfd_xcoff_link_generate_rtinit
 /* XCOFF support routines for ar.  */
 extern bfd_boolean bfd_xcoff_ar_archive_set_magic
   (bfd *, char *);
-
-/* Externally visible COFF routines.  */
-
-#if defined(__STDC__) || defined(ALMOST_STDC)
-struct internal_syment;
-union internal_auxent;
-#endif
-
-extern bfd_boolean bfd_coff_set_symbol_class
-  (bfd *, struct bfd_symbol *, unsigned int);
diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h
index 052a826..e7537f7 100644
--- a/bfd/bfd-in2.h
+++ b/bfd/bfd-in2.h
@@ -760,16 +760,6 @@ extern bfd_boolean bfd_xcoff_link_generate_rtinit
 /* XCOFF support routines for ar.  */
 extern bfd_boolean bfd_xcoff_ar_archive_set_magic
   (bfd *, char *);
-
-/* Externally visible COFF routines.  */
-
-#if defined(__STDC__) || defined(ALMOST_STDC)
-struct internal_syment;
-union internal_auxent;
-#endif
-
-extern bfd_boolean bfd_coff_set_symbol_class
-  (bfd *, struct bfd_symbol *, unsigned int);
 /* Extracted from init.c.  */
 unsigned int bfd_init (void);
 
diff --git a/bfd/coff-bfd.h b/bfd/coff-bfd.h
index 20c2a44..b88c5be 100644
--- a/bfd/coff-bfd.h
+++ b/bfd/coff-bfd.h
@@ -86,3 +86,6 @@ extern bfd_boolean bfd_coff_get_syment
 
 extern bfd_boolean bfd_coff_get_auxent
   (bfd *, struct bfd_symbol *, int, union internal_auxent *);
+
+extern bfd_boolean bfd_coff_set_symbol_class
+  (bfd *, struct bfd_symbol *, unsigned int);
diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index a2ac2b7..45817f4 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,5 +1,9 @@
 2019-09-23  Alan Modra  <amodra@gmail.com>
 
+	* dlltool.c: Include coff-bfd.h.
+
+2019-09-23  Alan Modra  <amodra@gmail.com>
+
 	PR 25018
 	* dwarf.c (get_type_signedness): Delete ineffective pointer
 	comparison check.  Properly range check uvalue offset on
diff --git a/binutils/dlltool.c b/binutils/dlltool.c
index 85304d0..6c4737e 100644
--- a/binutils/dlltool.c
+++ b/binutils/dlltool.c
@@ -240,6 +240,7 @@
 #include "bucomm.h"
 #include "dlltool.h"
 #include "safe-ctype.h"
+#include "coff-bfd.h"
 
 #include <time.h>
 #include <assert.h>



More information about the Binutils-cvs mailing list