[binutils-gdb] AArch64: Fix objdump tests

Tamar Christina tnfchris@sourceware.org
Thu Sep 19 12:17:00 GMT 2019


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4e28d4cc5b134a4027b4103ddaf09c19b8e0230b

commit 4e28d4cc5b134a4027b4103ddaf09c19b8e0230b
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Thu Sep 19 13:15:02 2019 +0100

    AArch64: Fix objdump tests
    
    The newly added objdump -S tests check for source line mapping of a static
    variable.  But the test doesn't dump any data sections so this should never
    pass.
    
    This changes the test to dump all sections so the source mapping can be found.
    
    binutils/ChangeLog:
    
    	* testsuite/binutils-all/objdump.exp (objdump -S): Update testcases.

Diff:
---
 binutils/ChangeLog                          | 4 ++++
 binutils/testsuite/binutils-all/objdump.exp | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 9f6300f..9d1aa84 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,7 @@
+2019-09-18  Tamar Christina  <tamar.christina@arm.com>
+
+	* testsuite/binutils-all/objdump.exp (objump -S): Update testcases.
+
 2019-09-18  Alan Modra  <amodra@gmail.com>
 
 	* addr2line.c, * bucomm.c, * coffgrok.c, * dlltool.c, * nm.c,
diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp
index 9630bac..58b66d4 100644
--- a/binutils/testsuite/binutils-all/objdump.exp
+++ b/binutils/testsuite/binutils-all/objdump.exp
@@ -818,7 +818,7 @@ proc test_objdump_S { } {
 	return
     }
 
-    set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS -S tmpdir/testprog"]
+    set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS -D -S tmpdir/testprog"]
 
     set want "static int local = 2"
 
@@ -830,7 +830,7 @@ proc test_objdump_S { } {
 
     set test "objdump --source-comment"
 
-    set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS --source-comment=// tmpdir/testprog"]
+    set got [binutils_run $OBJDUMP "$OBJDUMPFLAGS --disassemble-all --source-comment=// tmpdir/testprog"]
 
     set want "//static int local = 2"



More information about the Binutils-cvs mailing list