[binutils-gdb] sort_gnu_build_notes fix

Alan Modra amodra@sourceware.org
Sat Oct 26 02:41:00 GMT 2019


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1cc3da765d24068ef9046c19c9d23b1e69e30f6e

commit 1cc3da765d24068ef9046c19c9d23b1e69e30f6e
Author: Alan Modra <amodra@gmail.com>
Date:   Sat Oct 26 13:09:44 2019 +1030

    sort_gnu_build_notes fix
    
    	* objcopy.c (sort_gnu_build_notes): Correct sort of deleted
    	note2.

Diff:
---
 binutils/ChangeLog | 5 +++++
 binutils/objcopy.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 7a56ce4..b723f56 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,8 @@
+2019-10-26  Alan Modra  <amodra@gmail.com>
+
+	* objcopy.c (sort_gnu_build_notes): Correct sort of deleted
+	note2.
+
 2019-10-25  H.J. Lu  <hongjiu.lu@intel.com>
 
 	* elfedit.c (elf_x86_feature): Report unknown x86 feature.
diff --git a/binutils/objcopy.c b/binutils/objcopy.c
index 47c5310..7bdd447 100644
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -2067,7 +2067,7 @@ sort_gnu_build_notes (const void * data1, const void * data2)
 	return -1;
 
       if (is_deleted_note (pnote2))	/* 1: F   2: O D */
-	return 1;
+	return -1;
 
       return 1;				/* 1: F   2: O   */
     }



More information about the Binutils-cvs mailing list