[binutils-gdb] PowerPC comment fixes

Alan Modra amodra@sourceware.org
Fri Jun 14 03:54:00 GMT 2019


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d4b87b1eb6439e1cd01d1a9f90dcf19428db4b17

commit d4b87b1eb6439e1cd01d1a9f90dcf19428db4b17
Author: Alan Modra <amodra@gmail.com>
Date:   Fri Jun 14 10:22:49 2019 +0930

    PowerPC comment fixes
    
    "paddi rt,sym@pcrel" as an abbreviation for "paddi rt,0,sym@pcrel,1"
    is invalid, so replace with "pla rt,sym@pcrel" which is a valid form
    of "pla rt,sym@pcrel(0),1".
    
    	* elf64-ppc.c: Fix comments involving paddi.

Diff:
---
 bfd/ChangeLog   |  4 ++++
 bfd/elf64-ppc.c | 10 +++++-----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index b31e798..cb81fad 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,7 @@
+2019-06-14  Alan Modra  <amodra@gmail.com>
+
+	* elf64-ppc.c: Fix comments involving paddi.
+
 2019-06-12  Adam Lackorzymski  <adam@os.inf.tu-dresden.de>
 
 	PR 24643
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index f795e3f..9372ea4 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -2849,13 +2849,13 @@ must_be_dyn_reloc (struct bfd_link_info *info,
 
    There are also ELFv1 powerxx variants of these stubs.
    ppc_stub_long_branch_notoc:
-   .	paddi	%r12,dest@pcrel
+   .	pla	%r12,dest@pcrel
    .	b	dest
    ppc_stub_plt_branch_notoc:
    .	lis	%r11,(dest-1f)@highesta34
    .	ori	%r11,%r11,(dest-1f)@highera34
    .	sldi	%r11,%r11,34
-   . 1: paddi	%r12,dest@pcrel
+   . 1: pla	%r12,dest@pcrel
    .	add	%r12,%r11,%r12
    .	mtctr	%r12
    .	bctr
@@ -2863,7 +2863,7 @@ must_be_dyn_reloc (struct bfd_link_info *info,
    .	lis	%r11,(xxx-1f)@highesta34
    .	ori	%r11,%r11,(xxx-1f)@highera34
    .	sldi	%r11,%r11,34
-   . 1: paddi	%r12,xxx@pcrel
+   . 1: pla	%r12,xxx@pcrel
    .	ldx	%r12,%r11,%r12
    .	mtctr	%r12
    .	bctr
@@ -8191,7 +8191,7 @@ ok_lo_toc_insn (unsigned int insn, enum elf_ppc64_reloc_type r_type)
      pld ra,symbol@got@pcrel
      load/store rt,0(ra)
    or
-     paddi ra,symbol@pcrel
+     pla ra,symbol@pcrel
      load/store rt,0(ra)
    may be translated to
      pload/pstore rt,symbol@pcrel
@@ -8200,7 +8200,7 @@ ok_lo_toc_insn (unsigned int insn, enum elf_ppc64_reloc_type r_type)
    the prefix insn in *PINSN1 and a NOP in *PINSN2.
 
    On entry to this function, the linker has already determined that
-   the pld can be replaced with paddi: *PINSN1 is that paddi insn,
+   the pld can be replaced with pla: *PINSN1 is that pla insn,
    while *PINSN2 is the second instruction.  */
 
 static bfd_boolean



More information about the Binutils-cvs mailing list