[binutils-gdb] x86/Intel: drop pointless suffix setting for "fword ptr"

[Jan Beulich]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4cbda994e6c589b18c88227bf5a2fef089a18cfd

commit 4cbda994e6c589b18c88227bf5a2fef089a18cfd
Author: Jan Beulich <jbeulich@suse.com>
Date:   Mon Dec 9 13:29:14 2019 +0100

    x86/Intel: drop pointless suffix setting for "fword ptr"
    
    No floating point insn accepts an "fword ptr" operand, so the "fword"
    operand flag checking done by match_mem_size() is already sufficient;
    the setting of the suffix has become meaningless anyway with
    dc2be329b950 ("i386: Only check suffix in instruction mnemonic").

Diff:
---
 gas/ChangeLog              | 5 +++++
 gas/config/tc-i386-intel.c | 2 --
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 96bab96..70aff3d 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,5 +1,10 @@
 2019-12-09  Jan Beulich  <jbeulich@suse.com>
 
+	* config/tc-i386-intel.c (i386_intel_operand): Don't set suffix
+	for floating point insns when handling O_fword_ptr.
+
+2019-12-09  Jan Beulich  <jbeulich@suse.com>
+
 	* config/tc-i386-intel.c (i386_intel_operand): Don't special
 	case LDS et al when handling O_word_ptr.
 
diff --git a/gas/config/tc-i386-intel.c b/gas/config/tc-i386-intel.c
index ff5f0c6..bf8d9be 100644
--- a/gas/config/tc-i386-intel.c
+++ b/gas/config/tc-i386-intel.c
@@ -676,8 +676,6 @@ i386_intel_operand (char *operand_string, int got_a_float)
 		add_prefix (DATA_PREFIX_OPCODE);
 	      suffix = LONG_DOUBLE_MNEM_SUFFIX;
 	    }
-	  else
-	    suffix = BYTE_MNEM_SUFFIX; /* so it will cause an error */
 	  break;
 
 	case O_qword_ptr: