[binutils-gdb] Run a few more binutils tests non-native
Alan Modra
amodra@sourceware.org
Thu May 31 02:31:00 GMT 2018
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0034eed03a7428c4902244a33a286763bca65016
commit 0034eed03a7428c4902244a33a286763bca65016
Author: Alan Modra <amodra@gmail.com>
Date: Tue May 29 10:53:18 2018 +0930
Run a few more binutils tests non-native
Setting CC_FOR_TARGET from the environment CC was just plain wrong,
and no doubt the reason these tests were only run natively.
* testsuite/binutils-all/compress.exp (test_gnu_debuglink): Don't
set CC_FOR_TARGET. Run test non-native.
* testsuite/binutils-all/objdump.exp (test_build_id_debuglink):
Likewise.
(test_follow_debuglink): Run test non-native.
Diff:
---
binutils/ChangeLog | 8 ++++++++
binutils/testsuite/binutils-all/compress.exp | 10 +---------
binutils/testsuite/binutils-all/objdump.exp | 12 ++----------
3 files changed, 11 insertions(+), 19 deletions(-)
diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 8e1172a..c603c78 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,11 @@
+2018-05-31 Alan Modra <amodra@gmail.com>
+
+ * testsuite/binutils-all/compress.exp (test_gnu_debuglink): Don't
+ set CC_FOR_TARGET. Run test non-native.
+ * testsuite/binutils-all/objdump.exp (test_build_id_debuglink):
+ Likewise.
+ (test_follow_debuglink): Run test non-native.
+
2018-05-30 Ant Bikeneev <ant.bikineev@gmail.com>
PR 23107
diff --git a/binutils/testsuite/binutils-all/compress.exp b/binutils/testsuite/binutils-all/compress.exp
index edbe9dd..948d20a 100644
--- a/binutils/testsuite/binutils-all/compress.exp
+++ b/binutils/testsuite/binutils-all/compress.exp
@@ -677,19 +677,11 @@ proc test_gnu_debuglink {} {
global srcdir
global subdir
global env
- global CC_FOR_TARGET
global STRIP
global OBJCOPY
global OBJDUMP
set test "gnu-debuglink"
- if {![info exists CC_FOR_TARGET]} {
- set CC_FOR_TARGET $env(CC)
- }
- if { $CC_FOR_TARGET == "" } {
- unsupported $test
- return
- }
if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog exectuable debug] != "" } {
unsupported "$test (build)"
@@ -762,6 +754,6 @@ proc test_gnu_debuglink {} {
}
}
-if {[isnative] && [is_elf_format]} then {
+if {[is_elf_format]} then {
test_gnu_debuglink
}
diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp
index d9d0713..effc3dd 100644
--- a/binutils/testsuite/binutils-all/objdump.exp
+++ b/binutils/testsuite/binutils-all/objdump.exp
@@ -347,20 +347,12 @@ proc test_build_id_debuglink {} {
global srcdir
global subdir
global env
- global CC_FOR_TARGET
global STRIP
global OBJCOPY
global OBJDUMP
global CFLAGS_FOR_TARGET
set test "build-id-debuglink"
- if {![info exists CC_FOR_TARGET]} {
- set CC_FOR_TARGET $env(CC)
- }
- if { $CC_FOR_TARGET == "" } {
- unsupported $test
- return
- }
# Use a fixed build-id.
if { [info exists CFLAGS_FOR_TARGET] } {
@@ -427,7 +419,7 @@ proc test_build_id_debuglink {} {
}
}
-if {[isnative] && [is_elf_format]} then {
+if {[is_elf_format]} then {
test_build_id_debuglink
}
@@ -509,7 +501,7 @@ proc test_follow_debuglink {} {
set got [remote_exec host "rm tmpdir/linkdebug.debug"]
}
-if {[isnative] && [is_elf_format]} then {
+if {[is_elf_format]} then {
test_follow_debuglink
}
More information about the Binutils-cvs
mailing list