[binutils-gdb] NDS32/BFD: Fix build error in `nds32_convert_32_to_16'

Maciej W.Rozycki macro@sourceware.org
Wed May 16 19:44:00 GMT 2018


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=1624c9ca3fd32bf25b2cb63f99270abe41f718f5

commit 1624c9ca3fd32bf25b2cb63f99270abe41f718f5
Author: Maciej W. Rozycki <macro@mips.com>
Date:   Wed May 16 20:43:29 2018 +0100

    NDS32/BFD: Fix build error in `nds32_convert_32_to_16'
    
    Fix:
    
    cc1: warnings being treated as errors
    .../bfd/elf32-nds32.c: In function 'nds32_convert_32_to_16':
    .../bfd/elf32-nds32.c:6816: error: 'insn_type' may be used uninitialized in this function
    make[4]: *** [elf32-nds32.lo] Error 1
    
    seen with GCC 4.1.2 and 4.4.7.
    
    	bfd/
    	* elf32-nds32.c (nds32_convert_32_to_16): Preset `insn_type'.

Diff:
---
 bfd/ChangeLog     | 4 ++++
 bfd/elf32-nds32.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 8ef34ef..d2c5201 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,7 @@
+2018-05-16  Maciej W. Rozycki  <macro@mips.com>
+
+	* elf32-nds32.c (nds32_convert_32_to_16): Preset `insn_type'.
+
 2018-05-16  Alan Modra  <amodra@gmail.com>
 
 	PR 22458
diff --git a/bfd/elf32-nds32.c b/bfd/elf32-nds32.c
index 61f4800..1b30d12 100644
--- a/bfd/elf32-nds32.c
+++ b/bfd/elf32-nds32.c
@@ -6808,7 +6808,7 @@ nds32_convert_32_to_16 (bfd *abfd, uint32_t insn, uint16_t *pinsn16,
 {
   int op6;
   uint16_t insn16 = 0;
-  int insn_type;
+  int insn_type = 0;
   unsigned long mach = bfd_get_mach (abfd);
 
   /* Decode 32-bit instruction.  */



More information about the Binutils-cvs mailing list