[binutils-gdb] Fix uninitialised memory acccess in COFF bfd backend

Christophe Lyon clyon@sourceware.org
Tue May 15 12:34:00 GMT 2018


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=810ed4db984d378ca9c8e3d152966fb81c23ef95

commit 810ed4db984d378ca9c8e3d152966fb81c23ef95
Author: Christophe Guillon <christophe.guillon@st.com>
Date:   Tue May 15 12:27:45 2018 +0000

    Fix uninitialised memory acccess in COFF bfd backend
    
    2018-05-15  Christophe Guillon  <christophe.guillon@st.com>
    
    	* coffcode.h (coff_bigobj_swap_aux_in): Make sure that all fields
    	of the aux structure are initialised.
    
    Change-Id: I81be255ac6611afbe00995fac550e98e6a07e5df

Diff:
---
 bfd/ChangeLog  | 5 +++++
 bfd/coffcode.h | 3 +++
 2 files changed, 8 insertions(+)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 6e97ff2..655c0ad 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2018-05-15  Christophe Guillon  <christophe.guillon@st.com>
+
+	* coffcode.h (coff_bigobj_swap_aux_in): Make sure that all fields
+	of the aux structure are initialised.
+
 2018-05-15  Francois H. Theron  <francois.theron@netronome.com>
 
 	* targets.c: Wrap nfp_elf64_vec in BFD64 ifdef.
diff --git a/bfd/coffcode.h b/bfd/coffcode.h
index c63ebd2..6ad991c 100644
--- a/bfd/coffcode.h
+++ b/bfd/coffcode.h
@@ -5528,6 +5528,9 @@ coff_bigobj_swap_aux_in (bfd *abfd,
   AUXENT_BIGOBJ *ext = (AUXENT_BIGOBJ *) ext1;
   union internal_auxent *in = (union internal_auxent *) in1;
 
+  /* Make sure that all fields in the aux structure are
+     initialised.  */
+  memset (in, 0, sizeof * in);
   switch (in_class)
     {
     case C_FILE:



More information about the Binutils-cvs mailing list