[binutils-gdb] i386: Remove the unused bfd pointer argument

H.J.Lu hjl@sourceware.org
Sun Dec 23 17:47:00 GMT 2018


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b366503e45a2b28271dd12a7ca923964154c2716

commit b366503e45a2b28271dd12a7ca923964154c2716
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Sun Dec 23 09:45:29 2018 -0800

    i386: Remove the unused bfd pointer argument
    
    Remove the unused bfd pointer argument of elf_i386_rtype_to_howto.
    
    	* elf32-i386.c (elf_i386_rtype_to_howto): Remove the unused bfd
    	pointer argument.
    	(elf_i386_info_to_howto_rel): Updated.
    	(elf_i386_tls_transition): Likewise.
    	(elf_i386_relocate_section): Likewise.

Diff:
---
 bfd/ChangeLog    |  8 ++++++++
 bfd/elf32-i386.c | 10 +++++-----
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 70d1abf..84be63b 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,11 @@
+2018-12-23  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* elf32-i386.c (elf_i386_rtype_to_howto): Remove the unused bfd
+	pointer argument.
+	(elf_i386_info_to_howto_rel): Updated.
+	(elf_i386_tls_transition): Likewise.
+	(elf_i386_relocate_section): Likewise.
+
 2018-12-20  H.J. Lu  <hongjiu.lu@intel.com>
 
 	* elf32-i386.c (elf_i386_relocate_section): Call
diff --git a/bfd/elf32-i386.c b/bfd/elf32-i386.c
index f470b82..60581a2 100644
--- a/bfd/elf32-i386.c
+++ b/bfd/elf32-i386.c
@@ -370,7 +370,7 @@ elf_i386_reloc_name_lookup (bfd *abfd ATTRIBUTE_UNUSED,
 }
 
 static reloc_howto_type *
-elf_i386_rtype_to_howto (bfd *abfd ATTRIBUTE_UNUSED, unsigned r_type)
+elf_i386_rtype_to_howto (unsigned r_type)
 {
   unsigned int indx;
 
@@ -395,7 +395,7 @@ elf_i386_info_to_howto_rel (bfd *abfd,
 {
   unsigned int r_type = ELF32_R_TYPE (dst->r_info);
 
-  if ((cache_ptr->howto = elf_i386_rtype_to_howto (abfd, r_type)) == NULL)
+  if ((cache_ptr->howto = elf_i386_rtype_to_howto (r_type)) == NULL)
     {
       /* xgettext:c-format */
       _bfd_error_handler (_("%pB: unsupported relocation type %#x"),
@@ -1151,8 +1151,8 @@ elf_i386_tls_transition (struct bfd_link_info *info, bfd *abfd,
       reloc_howto_type *from, *to;
       const char *name;
 
-      from = elf_i386_rtype_to_howto (abfd, from_type);
-      to = elf_i386_rtype_to_howto (abfd, to_type);
+      from = elf_i386_rtype_to_howto (from_type);
+      to = elf_i386_rtype_to_howto (to_type);
 
       if (h)
 	name = h->root.root.string;
@@ -2080,7 +2080,7 @@ elf_i386_relocate_section (bfd *output_bfd,
 	  continue;
 	}
 
-      howto = elf_i386_rtype_to_howto (input_bfd, r_type);
+      howto = elf_i386_rtype_to_howto (r_type);
       if (howto == NULL)
 	return _bfd_unrecognized_reloc (input_bfd, input_section, r_type);



More information about the Binutils-cvs mailing list