[binutils-gdb] PowerPC64 "call lacks nop"

Alan Modra amodra@sourceware.org
Thu Aug 23 14:57:00 GMT 2018


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f53ad3cf2b2dc34114a9b74439da5a418ac40e3d

commit f53ad3cf2b2dc34114a9b74439da5a418ac40e3d
Author: Alan Modra <amodra@gmail.com>
Date:   Fri Aug 24 00:15:35 2018 +0930

    PowerPC64 "call lacks nop"
    
    The "-fPIC" and "-mcmodel=small" parts of these messages isn't always
    true, so lets dispense with that and just report the type of stub
    causing trouble.
    
    	* elf64-ppc.c (ppc64_elf_relocate_section): Revise "call lacks
    	nop" error message.

Diff:
---
 bfd/ChangeLog   | 5 +++++
 bfd/elf64-ppc.c | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 66eb071..97c8e08 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2018-08-23  Alan Modra  <amodra@gmail.com>
+
+	* elf64-ppc.c (ppc64_elf_relocate_section): Revise "call lacks
+	nop" error message.
+
 2018-08-23  Nick Clifton  <nickc@redhat.com>
 
 	* elf64-hppa.c (elf_hppa_final_link_relocate): Replace unworkable
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 1a40fa9..24855ed 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -13995,13 +13995,13 @@ ppc64_elf_relocate_section (bfd *output_bfd,
 		    info->callbacks->einfo
 		      /* xgettext:c-format */
 		      (_("%H: call to `%pT' lacks nop, can't restore toc; "
-			 "recompile with -fPIC\n"),
+			 "(plt call stub)\n"),
 		       input_bfd, input_section, rel->r_offset, sym_name);
 		  else
 		    info->callbacks->einfo
 		      /* xgettext:c-format */
 		      (_("%H: call to `%pT' lacks nop, can't restore toc; "
-			 "(-mcmodel=small toc adjust stub)\n"),
+			 "(toc save/adjust stub)\n"),
 		       input_bfd, input_section, rel->r_offset, sym_name);
 
 		  bfd_set_error (bfd_error_bad_value);



More information about the Binutils-cvs mailing list