[binutils-gdb] Fix fill-1 testcase

Andreas Krebbel krebbel@sourceware.org
Thu Oct 19 07:03:00 GMT 2017


https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=fa57faa0dad237b3f418f17e7ee2114c32da818a

commit fa57faa0dad237b3f418f17e7ee2114c32da818a
Author: Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Date:   Thu Oct 19 09:02:15 2017 +0200

    Fix fill-1 testcase
    
    This fixes various issues with the fill-1 testcase causing fails on a
    couple of targets.
    
    gas/ChangeLog:
    
    2017-10-19  Andreas Krebbel  <krebbel@linux.vnet.ibm.com>
    
    	* testsuite/gas/all/fill-1.s: Use normal labels.  Change .text to
    	.data. Pick different values.  Use .dc.w instead of .word.
    	* testsuite/gas/all/fill-1.d: New objdump output check.
    	* testsuite/gas/all/gas.exp: Use run_dump_test to execute fill-1
    	testcase.

Diff:
---
 gas/ChangeLog                  |  8 ++++++++
 gas/testsuite/gas/all/fill-1.d |  7 +++++++
 gas/testsuite/gas/all/fill-1.s | 12 +++++++-----
 gas/testsuite/gas/all/gas.exp  |  2 +-
 4 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/gas/ChangeLog b/gas/ChangeLog
index cb90c99..23b2faa 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,11 @@
+2017-10-19  Andreas Krebbel  <krebbel@linux.vnet.ibm.com>
+
+	* testsuite/gas/all/fill-1.s: Use normal labels.  Change .text to
+	.data. Pick different values.  Use .dc.w instead of .word.
+	* testsuite/gas/all/fill-1.d: New objdump output check.
+	* testsuite/gas/all/gas.exp: Use run_dump_test to execute fill-1
+	testcase.
+
 2017-10-18  Palmer Dabbelt  <palmer@dabbelt.com>
 
 	* testsuite/gas/all/align.d: Mark as unsupported on RISC-V.
diff --git a/gas/testsuite/gas/all/fill-1.d b/gas/testsuite/gas/all/fill-1.d
new file mode 100644
index 0000000..da5933e
--- /dev/null
+++ b/gas/testsuite/gas/all/fill-1.d
@@ -0,0 +1,7 @@
+#objdump: -s -j .data -j "\$DATA\$"
+#name: fill test with forward labels
+
+.*: +file format .*
+
+Contents of section (\.data|\$DATA\$):
+ [^ ]* 0a0a0d0d 0b0b0c0c .*
diff --git a/gas/testsuite/gas/all/fill-1.s b/gas/testsuite/gas/all/fill-1.s
index e72cbf1..34c52cc 100644
--- a/gas/testsuite/gas/all/fill-1.s
+++ b/gas/testsuite/gas/all/fill-1.s
@@ -1,5 +1,7 @@
-	.text
-	.fill (2f-1f), 1, 0x90
-1:
-        .word 42
-2:
+	.data
+	.dc.w 0x0a0a
+	.fill (.L2-.L1), 1, 0x0d
+.L1:
+	.dc.w 0x0b0b
+.L2:
+	.dc.w 0x0c0c
diff --git a/gas/testsuite/gas/all/gas.exp b/gas/testsuite/gas/all/gas.exp
index 6a68bcc..942b0b4 100644
--- a/gas/testsuite/gas/all/gas.exp
+++ b/gas/testsuite/gas/all/gas.exp
@@ -488,4 +488,4 @@ run_dump_test "org-4"
 run_dump_test "org-5"
 run_dump_test "org-6"
 
-gas_test "fill-1.s" "" "" "test .fill forward label references"
+run_dump_test "fill-1"



More information about the Binutils-cvs mailing list